Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFmpeg not installed | Request to be able to contribute to the project #7

Closed
HGriessel opened this issue Sep 2, 2023 · 1 comment
Closed

Comments

@HGriessel
Copy link
Contributor

Good day,

Thank you for the amazing work done on this project

I had an issue that was obvious after some debugging, and which should have been obviosue to me but I was running on a fresh os and did not think of installing FFmpeg

The error was suppressed/ignored on line 297 only after altering the code to the following did I get this error.

videoProbe, videoProbeError := ffmpeg.Probe(abs)
	
if videoProbeError != nil {
   log.Printf("Error: %v", err)
   return Video{}, fmt.Errorf("fatal error: %w", err)
}

I also added GetDuration as a method as it was/is useful for me to know the video's duration during runtime.

func (V Video) GetDuration() float64 {
	return V.duration
}

I am fairly new to go and have about 7 years of experience with Python and I am building a small project to cut my teeth on the Golang way of doing things. Would love to be able to contribute to the project as i am also looking for OSS projects to contribute towards.

@HGriessel
Copy link
Contributor Author

AndreaNicola also has this in the pull request https://github.com/AndreaNicola

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant