Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic style #50

Merged
merged 46 commits into from
Dec 28, 2015
Merged

Basic style #50

merged 46 commits into from
Dec 28, 2015

Conversation

mitogh
Copy link
Member

@mitogh mitogh commented Dec 1, 2015

No description provided.

mitogh and others added 21 commits October 30, 2015 20:02
wp_title has some issues. Returns name of blog empty. Fixed this.
Dropdown menu style with pure css/html.
Widen the menu wrapper to 100% and centerised the actual menu and some
color changes.
Comments section styled from scratch. Some fixes on header and footer.
Added new generated .scss files to app.scss. Overall responsive fixes in
responsive.scss. Added vatiables that used in fixes and new styles in
_variables.scss
Little changes on single page navigation and added margin to entry meta
data.
@@ -40,9 +39,13 @@ Tags:
3.0 Variables
--------------------------------------------------------------*/
@import "components/variables";
@import "components/content";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nucro the content, header, footer, and comments scss files should go in a folder named "modules" instead of "components". And they should be listed in a new section 7.0. please review this file for an example:
https://github.com/moxienyc/amtrak-journey/blob/develop/wp-content/themes/amtrak-journey/assets/sass/_app.scss

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we talked about this with @mitogh . I'll fix it after design and other things are approved. @jrrrsmith

*removed pushing effect.
*removed background color and changed color of next/prev buttons to
make them more link-ish.
@@ -47,10 +47,10 @@
<?php
/* translators: %1$s: smiley */
$archive_content = '<p>' . sprintf( __( 'Try looking in the monthly archives. %1$s', 'lean' ), convert_smilies( ':)' ) ) . '</p>';
the_widget( 'WP_Widget_Archives', 'dropdown=1', "after_title=</h2>$archive_content" );
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nucro don't change nothing of PHP, basic styles means only sass files, please keep things simple and focus only on 1 task at the time.

Thank you.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one seems interesting. I didn't change this and almost didn't touch this file. Even this line is still there in my local environment. @mitogh

*added link transition back
*Indent fixes on wordpress.scss,content.scss
*color variable enchancements
*link/hover enchancements
Added underscores to color names as prefix. Changed other variables
according to that.
*reverted to old state the php codes that changed mistakenly.
Removed experimental transition class.
Removed dropdown menu style to naked.
Removed tags that has no impact on CSS side.
Some color variables are changed from colorname to hex.
@mitogh mitogh assigned mitogh and unassigned orcunilbeyli Dec 23, 2015
mitogh added a commit that referenced this pull request Dec 28, 2015
@mitogh mitogh merged commit c3ec7ac into development Dec 28, 2015
@mitogh mitogh deleted the basic-style branch December 28, 2015 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants