-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic style #50
Basic style #50
Conversation
wp_title has some issues. Returns name of blog empty. Fixed this.
Dropdown menu style with pure css/html.
Widen the menu wrapper to 100% and centerised the actual menu and some color changes.
Comments section styled from scratch. Some fixes on header and footer. Added new generated .scss files to app.scss. Overall responsive fixes in responsive.scss. Added vatiables that used in fixes and new styles in _variables.scss
This reverts commit 0f76a61.
This reverts commit 95617d4.
Little changes on single page navigation and added margin to entry meta data.
@@ -40,9 +39,13 @@ Tags: | |||
3.0 Variables | |||
--------------------------------------------------------------*/ | |||
@import "components/variables"; | |||
@import "components/content"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nucro the content, header, footer, and comments scss files should go in a folder named "modules" instead of "components". And they should be listed in a new section 7.0. please review this file for an example:
https://github.com/moxienyc/amtrak-journey/blob/develop/wp-content/themes/amtrak-journey/assets/sass/_app.scss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we talked about this with @mitogh . I'll fix it after design and other things are approved. @jrrrsmith
@@ -47,10 +47,10 @@ | |||
<?php | |||
/* translators: %1$s: smiley */ | |||
$archive_content = '<p>' . sprintf( __( 'Try looking in the monthly archives. %1$s', 'lean' ), convert_smilies( ':)' ) ) . '</p>'; | |||
the_widget( 'WP_Widget_Archives', 'dropdown=1', "after_title=</h2>$archive_content" ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nucro don't change nothing of PHP, basic styles means only sass files, please keep things simple and focus only on 1 task at the time.
Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one seems interesting. I didn't change this and almost didn't touch this file. Even this line is still there in my local environment. @mitogh
*added link transition back *Indent fixes on wordpress.scss,content.scss *color variable enchancements *link/hover enchancements
Added underscores to color names as prefix. Changed other variables according to that.
*reverted to old state the php codes that changed mistakenly.
Removed experimental transition class.
Removed dropdown menu style to naked.
Removed tags that has no impact on CSS side.
Some color variables are changed from colorname to hex.
No description provided.