Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable unit tests that use private resources #366

Merged
merged 9 commits into from
May 17, 2019

Conversation

dongyoungy
Copy link
Contributor

This is an attempt to enable automatic unit tests on external pull requests via CircleCI.
This PR:

  1. disable unit tests using our private resources via @Ignore annotation
  2. comment out git pull on our private resources in the CircleCI configuration

Please note that:

  1. Currently our Redshift test instance is down, so CircleCI tests will fail
  2. There has been issue with CircleCI image that we use for our jdk7 tests: https://discuss.circleci.com/t/apt-get-update-return-404/29237/8
    I have included a temporary fix to it, but we may need to use a different image for a proper fix.

@dongyoungy dongyoungy requested a review from pyongjoo May 15, 2019 19:00
@pyongjoo
Copy link
Member

I think it looks good. Let me disable the private repo itself and let you know. In this way, we can fundamentally guarantee no access to the repo.

@pyongjoo
Copy link
Member

@dongyoungy Currently, the errors are due to our stopped Redshift cluster. Can you also simply deactivate those unit tests?

@pyongjoo
Copy link
Member

@dongyoungy Can you fix the error and merge this to the master? Not urgent, but I would like to base my branch on this.

@codecov-io
Copy link

Codecov Report

Merging #366 into master will decrease coverage by 2.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
- Coverage    70.9%   68.64%   -2.25%     
==========================================
  Files         168      168              
  Lines       11517    11517              
  Branches     1879     1879              
==========================================
- Hits         8165     7905     -260     
- Misses       2868     3106     +238     
- Partials      484      506      +22
Impacted Files Coverage Δ
...n/java/org/verdictdb/sqlsyntax/RedshiftSyntax.java 5.56% <0%> (-72.22%) ⬇️
...erdictdb/core/scrambling/ScramblingMethodBase.java 57.9% <0%> (-31.57%) ⬇️
...rdictdb/core/querying/CreateTableAsSelectNode.java 65.52% <0%> (-24.13%) ⬇️
...ava/org/verdictdb/metastore/ScrambleMetaStore.java 67.23% <0%> (-23.88%) ⬇️
...ictdb/core/scrambling/UniformScramblingMethod.java 70.32% <0%> (-21.87%) ⬇️
...org/verdictdb/sqlreader/ScrambleTableReplacer.java 65.56% <0%> (-16.66%) ⬇️
...ain/java/org/verdictdb/commons/StringSplitter.java 82.76% <0%> (-13.79%) ⬇️
...va/org/verdictdb/coordinator/ExecutionContext.java 71.67% <0%> (-13.35%) ⬇️
src/main/java/org/verdictdb/sqlreader/CondGen.java 66.67% <0%> (-8.77%) ⬇️
...in/java/org/verdictdb/sqlreader/ExpressionGen.java 75.31% <0%> (-7.22%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a29dc0b...b044e37. Read the comment docs.

@dongyoungy
Copy link
Contributor Author

dongyoungy commented May 17, 2019

I have further disabled unit tests with redshift and since all unit tests get passed, I am merging this PR.

@dongyoungy dongyoungy merged commit 29fd9a9 into master May 17, 2019
@dongyoungy dongyoungy deleted the dyoon-disable-private-test branch May 17, 2019 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants