-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable unit tests that use private resources #366
Conversation
I think it looks good. Let me disable the private repo itself and let you know. In this way, we can fundamentally guarantee no access to the repo. |
@dongyoungy Currently, the errors are due to our stopped Redshift cluster. Can you also simply deactivate those unit tests? |
@dongyoungy Can you fix the error and merge this to the master? Not urgent, but I would like to base my branch on this. |
Codecov Report
@@ Coverage Diff @@
## master #366 +/- ##
==========================================
- Coverage 70.9% 68.64% -2.25%
==========================================
Files 168 168
Lines 11517 11517
Branches 1879 1879
==========================================
- Hits 8165 7905 -260
- Misses 2868 3106 +238
- Partials 484 506 +22
Continue to review full report at Codecov.
|
I have further disabled unit tests with redshift and since all unit tests get passed, I am merging this PR. |
This is an attempt to enable automatic unit tests on external pull requests via CircleCI.
This PR:
@Ignore
annotationgit pull
on our private resources in the CircleCI configurationPlease note that:
I have included a temporary fix to it, but we may need to use a different image for a proper fix.