Improve table semantics using thead and tbody instead of a standard row as header #675
Conversation
|
By analyzing the blame information on this pull request, we identified @pascalchevrel, @TheoChevalier and @tx2z to be potential reviewers |
|
|
||
| $section_title = "Strings that have changed significantly in English between {$repo_one} and {$repo_two} but for which the entity name didn’t change"; | ||
| $table = " | ||
| <p class='section_title'>{$section_title}</p> |
There was a problem hiding this comment.
If it's a title maybe it should use a tag ?
There was a problem hiding this comment.
Not completely sure: it's not an actual title, more a subtitle, and before it was even more confusing (part of the table). The actual title would be the one above (linked as an anchor).
There was a problem hiding this comment.
(it might make sense to change the class name, e.g. section_description or similar)
There was a problem hiding this comment.
or many a th that would span all columns if it's part of the table, or a caption tag?
There was a problem hiding this comment.
Let me check how <caption> is displayed.
There was a problem hiding this comment.
Tried but it would require quite a few changes, especially for smaller viewports (it breaks quite badly), and I'm not completely convinced that it should be part of the table.
Also add min-width to tables
|
Updated variable/CSS class name in a separate commit. Not sure if we should drop the bold too. |
Improve table semantics using thead and tbody instead of a standard row as header
|
oops, missed that it wasn't squashed yet :( |
Strip tags in unlocalized view, that also improves results (e.g. for words like "tag", "file", etc.).
Also fixes #670