Differentiate empty from missing strings #768
Conversation
| @@ -34,7 +34,7 @@ | |||
| " <th><a href='#{$locale}'>{$locale}</a></th>\n"; | |||
|
|
|||
| if (! $translation) { | |||
| echo " <td><em class='error'>Warning: Missing string</em></td><td></td>\n"; | |||
| echo " <td><em class='error'>Warning: Empty string</em></td><td></td>\n"; | |||
There was a problem hiding this comment.
I’m confused why you left only “Empty”. Now on http://localhost:8082/string/?entity=dom/chrome/dom/dom.properties:GenericImageNamePNG&repo=central it’s displaying "Empty string” everywhere while the string is missing.
|
Not sure if there’s something missing, but I tried a few queries with a brand new dev server (data got corrupt on my full install), and I see “Warning: Empty string” everywhere. Even for Venkman strings for instance, and they are gone from locale repos |
|
There something wrong with my local VM, I switched the dev server to my branch and I see your same errors. Will need to look into it next week. |
|
You're right about showing "Missing string" in onestring, I can't understand why the online servers are still showing Venkman, when they shouldn't |
|
Let's close this one. I realized it needs a lot more work, starting from extraction :-\ |
|
This might be ready for some more tests. To test, you need to recreate TMX caches, you can do that setting One string (view and API): it should only show the strings we actually have, or strings that are empty. I tried to go through the code and identify places where we assumed empty=missing, but I only found places where we wrongly assumed that missing strings would be missing from the TMX. Changes to tmx_products.py are also in its own repo upstream, with tests |
|
Looks good 👍 We’ll have to remember recreating TMX files on the server for the next release |
Fix #767