New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jpm sign submits listed add-on for review which is unexpected #467

Open
als123 opened this Issue Jan 22, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@als123

als123 commented Jan 22, 2016

I experimented with 'jpm sign' while updating a listed add-on. It told me:

JPM [info] Your add-on has been submitted for review. It passed validation but could not be automatically signed because this is a listed add-on.
JPM [info] FAIL

As a result it went into the queue for preliminary review and before you could say jack robinson it was listed on AMO as the next version of the add-on! I had to go and disable that version.

How about not doing any more than I ask for?!

@kumar303 kumar303 changed the title from jpm sign goes out of control to jpm sign submits listed add-on for review which is unexpected Jan 22, 2016

@kumar303

This comment has been minimized.

Show comment
Hide comment
@kumar303

kumar303 Jan 22, 2016

Member

Ah, yeah, I suppose that is a little unexpected.

Member

kumar303 commented Jan 22, 2016

Ah, yeah, I suppose that is a little unexpected.

@freaktechnik

This comment has been minimized.

Show comment
Hide comment
@freaktechnik

freaktechnik Feb 1, 2016

Member

What about appending -pre to the version number, so it would be on the beta-channel for fully reviewed extensions?

Member

freaktechnik commented Feb 1, 2016

What about appending -pre to the version number, so it would be on the beta-channel for fully reviewed extensions?

@kumar303

This comment has been minimized.

Show comment
Hide comment
@kumar303

kumar303 Feb 1, 2016

Member

Personally I'm not familiar with how that affects the review queue but it may be an acceptable workaround. The real fix is probably to patch this API http://olympia.readthedocs.org/en/latest/topics/api/signing.html#put--api-v3-addons-[string-add-on-id]-versions-[string-version]- The signing API is really not useful for listed add-ons at all anyway. If your add-on is listed on AMO then it will automatically be signed.

Member

kumar303 commented Feb 1, 2016

Personally I'm not familiar with how that affects the review queue but it may be an acceptable workaround. The real fix is probably to patch this API http://olympia.readthedocs.org/en/latest/topics/api/signing.html#put--api-v3-addons-[string-add-on-id]-versions-[string-version]- The signing API is really not useful for listed add-ons at all anyway. If your add-on is listed on AMO then it will automatically be signed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment