Skip to content
This repository has been archived by the owner before Nov 9, 2022. It is now read-only.

jpm sign submits listed add-on for review which is unexpected #467

Open
als123 opened this issue Jan 22, 2016 · 3 comments
Open

jpm sign submits listed add-on for review which is unexpected #467

als123 opened this issue Jan 22, 2016 · 3 comments

Comments

@als123
Copy link

als123 commented Jan 22, 2016

I experimented with 'jpm sign' while updating a listed add-on. It told me:

JPM [info] Your add-on has been submitted for review. It passed validation but could not be automatically signed because this is a listed add-on.
JPM [info] FAIL

As a result it went into the queue for preliminary review and before you could say jack robinson it was listed on AMO as the next version of the add-on! I had to go and disable that version.

How about not doing any more than I ask for?!

@kumar303 kumar303 changed the title jpm sign goes out of control jpm sign submits listed add-on for review which is unexpected Jan 22, 2016
@kumar303
Copy link
Contributor

kumar303 commented Jan 22, 2016

Ah, yeah, I suppose that is a little unexpected.

@freaktechnik
Copy link
Contributor

freaktechnik commented Feb 1, 2016

What about appending -pre to the version number, so it would be on the beta-channel for fully reviewed extensions?

@kumar303
Copy link
Contributor

kumar303 commented Feb 1, 2016

Personally I'm not familiar with how that affects the review queue but it may be an acceptable workaround. The real fix is probably to patch this API http://olympia.readthedocs.org/en/latest/topics/api/signing.html#put--api-v3-addons-[string-add-on-id]-versions-[string-version]- The signing API is really not useful for listed add-ons at all anyway. If your add-on is listed on AMO then it will automatically be signed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants