Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

hide pw after navigating away from itemlist #1049

Merged
merged 2 commits into from Jun 10, 2019
Merged

hide pw after navigating away from itemlist #1049

merged 2 commits into from Jun 10, 2019

Conversation

sashei
Copy link
Contributor

@sashei sashei commented Jun 7, 2019 •
edited

Fixes #1042

Testing and Review Notes

bug repro steps are good

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • add unit tests
  • make sure CI builds are passing (e.g.: fix lint and other errors)

@sashei sashei requested a review from a team as a code owner June 7, 2019 15:51
linuxwolf
linuxwolf approved these changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@linuxwolf linuxwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

🙈

devinreams
devinreams approved these changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@devinreams devinreams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These steps are confirmed fixed on Build 3523 navigating from entry to list back to entry ✅

@devinreams devinreams merged commit 1f46c6b into master Jun 10, 2019
@devinreams devinreams deleted the 1042-hide-pw-after-navigating branch June 10, 2019 21:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devinreams devinreams devinreams approved these changes

@linuxwolf linuxwolf linuxwolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sashei @devinreams @linuxwolf