Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

hide pw after navigating away from itemlist #1049

Merged
merged 2 commits into from Jun 10, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions lockbox-ios/Presenter/ItemDetailPresenter.swift
Expand Up @@ -144,6 +144,10 @@ class ItemDetailPresenter {
.disposed(by: self.disposeBag)
}

func onViewDisappear() {
self.dispatcher.dispatch(action: ItemDetailDisplayAction.togglePassword(displayed: false))
}

func dndStarted(value: String?) {
self.itemDetailStore.itemDetailId
.take(1)
Expand Down
5 changes: 5 additions & 0 deletions lockbox-ios/View/ItemDetailView.swift
Expand Up @@ -80,6 +80,11 @@ class ItemDetailView: UIViewController {
self.setupDelegate()
self.presenter?.onViewReady()
}

override func viewWillDisappear(_ animated: Bool) {
super.viewWillDisappear(animated)
self.presenter?.onViewDisappear()
}
}

extension ItemDetailView: ItemDetailViewProtocol {
Expand Down
11 changes: 11 additions & 0 deletions lockbox-iosTests/ItemDetailPresenterSpec.swift
Expand Up @@ -507,6 +507,17 @@ class ItemDetailPresenterSpec: QuickSpec {
}
}

describe(".onViewDisappear") {
beforeEach {
self.subject.onViewDisappear()
}

it("toggles the password to hidden") {
let action = self.dispatcher.dispatchActionArgument.last as! ItemDetailDisplayAction
expect(action).to(equal(.togglePassword(displayed: false)))
}
}

describe(".onViewReady for view with sidebar") {
beforeEach {
self.view.itemDetailObserver = self.scheduler.createObserver([ItemDetailSectionModel].self)
Expand Down