Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Bug 1631834 - Allow action tasks to be executed #6993

Merged
merged 1 commit into from
May 18, 2020

Conversation

JohanLorenzo
Copy link
Contributor

@JohanLorenzo JohanLorenzo commented May 15, 2020

Backports mozilla-mobile/reference-browser#1182, mozilla-mobile/fenix#10644 and mozilla-mobile/fenix#10650 to android-components


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #6993 into master will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6993      +/-   ##
============================================
- Coverage     76.82%   76.61%   -0.22%     
+ Complexity     4880     4644     -236     
============================================
  Files           655      642      -13     
  Lines         24180    23337     -843     
  Branches       3535     3454      -81     
============================================
- Hits          18577    17880     -697     
+ Misses         4122     4016     -106     
+ Partials       1481     1441      -40     
Impacted Files Coverage Δ Complexity Δ
...a/components/browser/toolbar/facts/ToolbarFacts.kt
...lla/components/browser/toolbar/edit/EditToolbar.kt
...zilla/components/browser/toolbar/BrowserToolbar.kt
...r/toolbar/behavior/BrowserToolbarBottomBehavior.kt
...ts/browser/toolbar/display/SiteSecurityIconView.kt
...onents/browser/toolbar/internal/ActionContainer.kt
...wser/toolbar/display/TrackingProtectionIconView.kt
...mponents/browser/toolbar/display/DisplayToolbar.kt
...browser/toolbar/behavior/BrowserGestureDetector.kt
...mponents/browser/toolbar/internal/ActionWrapper.kt
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2424d12...1d7408e. Read the comment docs.

@JohanLorenzo
Copy link
Contributor Author

bors r=MihaiTabara

bors bot pushed a commit that referenced this pull request May 18, 2020
6993: Bug 1631834 - Allow action tasks to be executed r=MihaiTabara a=JohanLorenzo

Backports mozilla-mobile/reference-browser#1182, mozilla-mobile/fenix#10644 and mozilla-mobile/fenix#10650 to android-components



Co-authored-by: Johan Lorenzo <jlorenzo@mozilla.com>
@JohanLorenzo
Copy link
Contributor Author

bors merge-

@bors
Copy link

bors bot commented May 18, 2020

Canceled.

@JohanLorenzo
Copy link
Contributor Author

bors r=MihaiTabara

bors bot pushed a commit that referenced this pull request May 18, 2020
6993: Bug 1631834 - Allow action tasks to be executed r=MihaiTabara a=JohanLorenzo

Backports mozilla-mobile/reference-browser#1182, mozilla-mobile/fenix#10644 and mozilla-mobile/fenix#10650 to android-components



Co-authored-by: Johan Lorenzo <jlorenzo@mozilla.com>
@JohanLorenzo
Copy link
Contributor Author

bors merge-

@bors
Copy link

bors bot commented May 18, 2020

Canceled.

@JohanLorenzo
Copy link
Contributor Author

bors r=MihaiTabara

@bors
Copy link

bors bot commented May 18, 2020

Build succeeded:

@bors bors bot merged commit 792c7c0 into mozilla-mobile:master May 18, 2020
@JohanLorenzo JohanLorenzo deleted the bug-1631834 branch May 18, 2020 16:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants