This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Bug 1631834 - part 2: Express who triggered the action task #10650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MihaiTabara
approved these changes
May 14, 2020
This was referenced May 15, 2020
bors bot
pushed a commit
to mozilla-mobile/android-components
that referenced
this pull request
May 18, 2020
6993: Bug 1631834 - Allow action tasks to be executed r=MihaiTabara a=JohanLorenzo Backports mozilla-mobile/reference-browser#1182, mozilla-mobile/fenix#10644 and mozilla-mobile/fenix#10650 to android-components Co-authored-by: Johan Lorenzo <jlorenzo@mozilla.com>
bors bot
pushed a commit
to mozilla-mobile/android-components
that referenced
this pull request
May 18, 2020
6993: Bug 1631834 - Allow action tasks to be executed r=MihaiTabara a=JohanLorenzo Backports mozilla-mobile/reference-browser#1182, mozilla-mobile/fenix#10644 and mozilla-mobile/fenix#10650 to android-components Co-authored-by: Johan Lorenzo <jlorenzo@mozilla.com>
bors bot
pushed a commit
to mozilla-mobile/android-components
that referenced
this pull request
May 18, 2020
6993: Bug 1631834 - Allow action tasks to be executed r=MihaiTabara a=JohanLorenzo Backports mozilla-mobile/reference-browser#1182, mozilla-mobile/fenix#10644 and mozilla-mobile/fenix#10650 to android-components Co-authored-by: Johan Lorenzo <jlorenzo@mozilla.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excellent news! #10644 worked like a charm! I was able to rerun/retrigger/cancel tasks on the Fenix repo! @Archaeopteryx tried it out too, and it worked. He noticed one nit: the action tasks don't tell who triggered them (they do in Gecko). It turns out the fix is simple. I just backported the bits from https://searchfox.org/mozilla-central/rev/9f074fab9bf905fad62e7cc32faf121195f4ba46/.taskcluster.yml#94
Pull Request checklist
After merge
To download an APK when reviewing a PR: