Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Bug 1631834 - part 2: Express who triggered the action task #10650

Merged
merged 1 commit into from
May 14, 2020
Merged

Bug 1631834 - part 2: Express who triggered the action task #10650

merged 1 commit into from
May 14, 2020

Conversation

JohanLorenzo
Copy link
Contributor

Excellent news! #10644 worked like a charm! I was able to rerun/retrigger/cancel tasks on the Fenix repo! @Archaeopteryx tried it out too, and it worked. He noticed one nit: the action tasks don't tell who triggered them (they do in Gecko). It turns out the fix is simple. I just backported the bits from https://searchfox.org/mozilla-central/rev/9f074fab9bf905fad62e7cc32faf121195f4ba46/.taskcluster.yml#94

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

MihaiTabara
MihaiTabara approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@MihaiTabara MihaiTabara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ to adding these bits to improve traceability

@JohanLorenzo JohanLorenzo merged commit ca9f995 into mozilla-mobile:master May 14, 2020
@JohanLorenzo JohanLorenzo deleted the bug-1631834-2 branch May 14, 2020 14:45
This was referenced May 15, 2020
Merged
Merged
bors bot pushed a commit to mozilla-mobile/android-components that referenced this pull request May 18, 2020
@MozLando @JohanLorenzo
Merge #6993
a588554 
6993: Bug 1631834 - Allow action tasks to be executed r=MihaiTabara a=JohanLorenzo

Backports mozilla-mobile/reference-browser#1182, mozilla-mobile/fenix#10644 and mozilla-mobile/fenix#10650 to android-components



Co-authored-by: Johan Lorenzo <jlorenzo@mozilla.com>
bors bot pushed a commit to mozilla-mobile/android-components that referenced this pull request May 18, 2020
@MozLando @JohanLorenzo
Merge #6993
a65403b 
6993: Bug 1631834 - Allow action tasks to be executed r=MihaiTabara a=JohanLorenzo

Backports mozilla-mobile/reference-browser#1182, mozilla-mobile/fenix#10644 and mozilla-mobile/fenix#10650 to android-components



Co-authored-by: Johan Lorenzo <jlorenzo@mozilla.com>
bors bot pushed a commit to mozilla-mobile/android-components that referenced this pull request May 18, 2020
@MozLando @JohanLorenzo
Merge #6993
792c7c0 
6993: Bug 1631834 - Allow action tasks to be executed r=MihaiTabara a=JohanLorenzo

Backports mozilla-mobile/reference-browser#1182, mozilla-mobile/fenix#10644 and mozilla-mobile/fenix#10650 to android-components



Co-authored-by: Johan Lorenzo <jlorenzo@mozilla.com>
@liuche liuche mentioned this pull request May 19, 2020
Closed
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MihaiTabara MihaiTabara MihaiTabara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohanLorenzo @MihaiTabara