Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Close #8904 Use the gecko fetch client when resuming a download #8906

Merged
merged 2 commits into from Nov 6, 2020

Conversation

Amejia481
Copy link
Contributor

Before adding the new gecko view download API. We used to use the gecko fetch client that has the corresponding header for performing the resuming download. Now that we are always using the new API when available, resuming downloads are failing, as the new gv download API doesn't allow to pass headers we have to use the gecko fetch client when performing a resuming a download. Related issue mozilla-mobile/fenix#9354

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

Copy link
Contributor

@csadilek csadilek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Amejia481 Amejia481 added 🛬 needs landing PRs that are ready to land and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Nov 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants