Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Closes #8943 refactor SwipeRefreshFeature to not use EngineSession.Observer #8944

Merged
merged 1 commit into from Nov 12, 2020
Merged

Closes #8943 refactor SwipeRefreshFeature to not use EngineSession.Observer #8944

merged 1 commit into from Nov 12, 2020

Conversation

Amejia481
Copy link
Contributor

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@Amejia481 Amejia481 added the 🕵️‍♀️ needs review PRs that need to be reviewed label Nov 11, 2020
@Amejia481 Amejia481 removed the request for review from pocmo November 11, 2020 04:42
Mugurell
Mugurell approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@Mugurell Mugurell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...ents/feature/session/src/main/java/mozilla/components/feature/session/SwipeRefreshFeature.kt Show resolved Hide resolved
csadilek
csadilek approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@csadilek csadilek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I think this worked out and cleaned things up at the same time. Just a nit to add a bit more docs.

components/browser/state/src/main/java/mozilla/components/browser/state/state/ContentState.kt Show resolved Hide resolved
@Amejia481 Amejia481 added 🛬 needs landing PRs that are ready to land and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Nov 12, 2020
@mergify mergify bot merged commit e7100fe into mozilla-mobile:master Nov 12, 2020
This was referenced Nov 12, 2020
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csadilek csadilek csadilek approved these changes

@Mugurell Mugurell Mugurell approved these changes

Assignees

@csadilek csadilek

@Mugurell Mugurell

Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Amejia481 @csadilek @Mugurell