Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Investigate baseline ping eligibility for ad_clicks, in_content and with_ads #10599

Closed
psymoon opened this issue May 12, 2020 · 1 comment
Closed

Investigate baseline ping eligibility for ad_clicks, in_content and with_ads #10599

psymoon opened this issue May 12, 2020 · 1 comment
Assignees
@liuche @BranescuMihai
Labels
Feature:Telemetry

Comments

@psymoon
Copy link
Contributor

psymoon commented May 12, 2020 •
edited by data-sync-user

New glean update now returns error code for "unnecessary" baseline pings:

ERROR: BASELINE_PING: browser.search.ad_clicks: The baseline ping is Glean-internal. User metrics should go into the 'metrics' ping or custom pings.
ERROR: BASELINE_PING: browser.search.in_content: The baseline ping is Glean-internal. User metrics should go into the 'metrics' ping or custom pings.
ERROR: BASELINE_PING: browser.search.with_ads: The baseline ping is Glean-internal. User metrics should go into the 'metrics' ping or custom pings.

┆Issue is synchronized with this Jira Task
@github-actions github-actions bot added the needs:triage Issue needs triage label May 12, 2020
@psymoon psymoon mentioned this issue May 12, 2020
Merged
@liuche liuche mentioned this issue May 12, 2020
Closed
5 tasks
@ekager ekager removed the needs:triage Issue needs triage label May 12, 2020
@liuche liuche added this to Prioritized Backlog in Fenix Sprint Kanban May 12, 2020
BranescuMihai added a commit to BranescuMihai/fenix that referenced this issue May 13, 2020
@BranescuMihai
For mozilla-mobile#10599 - Removed baseline pings form metrics.yaml
0fab148 
As per documentation, this ping is intended to provide metrics that are managed by the library itself, and not explicitly set by the application or included in the application's metrics.yaml file.
liuche pushed a commit that referenced this issue May 13, 2020
@BranescuMihai @liuche
For #10599 - Removed baseline pings form metrics.yaml
d6b448e 
As per documentation, this ping is intended to provide metrics that are managed by the library itself, and not explicitly set by the application or included in the application's metrics.yaml file.
@liuche
Copy link
Contributor

liuche commented May 13, 2020

Going to close this because these have been removed from baseline ping, not worth while to QA because the lint will catch any more baseline problems.

@liuche liuche closed this as completed May 13, 2020
Fenix Sprint Kanban automation moved this from Prioritized Backlog to Sprint 20.9 Done May 13, 2020
@liuche liuche mentioned this issue May 19, 2020
Closed
32 tasks
@data-sync-user data-sync-user changed the title Investigate baseline ping eligibility for ad_clicks, in_content and with_ads FNX2-16041 ⁃ Investigate baseline ping eligibility for ad_clicks, in_content and with_ads Jul 31, 2020
@data-sync-user data-sync-user changed the title FNX2-16041 ⁃ Investigate baseline ping eligibility for ad_clicks, in_content and with_ads FNX-4408 ⁃ Investigate baseline ping eligibility for ad_clicks, in_content and with_ads Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX-4408 ⁃ Investigate baseline ping eligibility for ad_clicks, in_content and with_ads FNX3-14017 ⁃ Investigate baseline ping eligibility for ad_clicks, in_content and with_ads Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-14017 ⁃ Investigate baseline ping eligibility for ad_clicks, in_content and with_ads FNX2-16041 ⁃ Investigate baseline ping eligibility for ad_clicks, in_content and with_ads Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX2-16041 ⁃ Investigate baseline ping eligibility for ad_clicks, in_content and with_ads FNX-4408 ⁃ Investigate baseline ping eligibility for ad_clicks, in_content and with_ads Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-4408 ⁃ Investigate baseline ping eligibility for ad_clicks, in_content and with_ads Investigate baseline ping eligibility for ad_clicks, in_content and with_ads May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@liuche liuche

@BranescuMihai BranescuMihai

Labels
Feature:Telemetry
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@liuche @BranescuMihai @psymoon @ekager @Diana-Rus @data-sync-user