Ad click attribution counts

[liuche]

As part of search attribution parity with Desktop, we also need to collect

• Count of partner search pages w/ ads
• Count of ad clicks

Acceptance Criteria

• Telemetry type created that is similar to the desktop browser.search Scalar, or a similar data format cleared by Frank Bertsch (Data Engineering) This should be labeled_counter
• Request list of partner urls from Mike Connor @mconnormoz
• Data review (Desktop data review request here)
• Count of pages loaded that match partner search provider pages (that are assumed to have ads) browser.search.with_ads
• Count of ad clicks browser.search.ad_clicks (like a redirect)

Helpful context

• Desktop ad detection implementation (see SEARCH_ADD_CLICKS_SCALAR and SEARCH_WITH_ADS_SCALAR)
• Desktop tests for browser.search.ad_clicks code
• Blog post explaining Desktop ad display/click + organic search

┆Issue is synchronized with this Jira Task

[liuche]

I'm in the process of asking mconnor for these lists, if someone picks up this issue and the info isn't ready yet, please ping me!

[BranescuMihai]

@liuche, when the list of partner urls is available, please let me know :)

[Standard8]

* Desktop [tests](https://searchfox.org/mozilla-central/source/browser/components/search/test/unit/test_urlTelemetry.js) for `browser.search.ad_clicks` code

There is also https://searchfox.org/mozilla-central/source/browser/components/search/test/browser/browser_searchTelemetry.js

[liuche]

Hi @BranescuMihai, you should have access to the docs and links, I added you to an email thread and doc.

[BranescuMihai]

Hey @liuche, yep, I just noticed that, somehow it was lost between emails, thank you!

[vesta0]

Spoke to mconnor about this issue. This is not a MUST for the launch but should be a fast follower.

[dbolter]

Given the strategy shift in launch, @liuche do we have time to get this in?

[liuche]

Hi @BranescuMihai is this something you can pick up again?

[Diana-Rus]

Hi, verified this issue with the following scenarios on Nightly 4/28 and Beta 5.0.0-beta.1 - 4/29:

A). Searches without ads - no tracking is done as there are no ads
Google -> Ping - a6658f57-30a3-4ef6-89a6-60726137b865
Bing -> Ping - 336e141d-f4ca-4145-acf7-c889547d8000
Duckduckgo -> Ping - b2a8e7f0-7aa7-42e6-a7e0-0034bf177b14

B). Searches with ads & Ads clicked from searches

1. Google Engine - count of one search with ads. Ping- 9fc93a95-4e11-49b4-8282-9921192eb75a ✔️
2. Google Engine - count two searches with ads. Ping- 78202251-b51c-47e9-86db-d178dcfcb66e ✔️
3. Google Engine - count of clicked ads. Ping- fadba36e-7ea5-4e53-8310-53ce31093b8a ✔️
4. Bing Engine - count of one search with ads. Ping- 477f17cd-934d-43d5-9fa4-4087fab877c0 ✔️
5. Bing Engine - count two searches with ads. Ping- b0b53ad8-b54a-4bce-b9ae-2d45d3a60035 ✔️
6. Bing Engine - count of clicked ads. Ping-477f17cd-934d-43d5-9fa4-4087fab877c0 ✔️
7. Duckduckgo Engine - count of one search with ads. Ping-a2ac5c05-8ac4-4149-b811-7d956e8d6e88 ✔️
8. Duckduckgo Engine - count two searches with ads. Ping - af15d27a-90bd-4c12-992f-966490d6747d ✔️
9. Duckduckgo Engine - count of clicked ads. Ping - af15d27a-90bd-4c12-992f-966490d6747d ✔️
10. Combination of searches and ads made on different search engines through search shorcuts. Baseline Ping - a28db793-1180-40a5-910c-8c0a81484f12 ✔️

[Glean dashboard] - Nightly - https://debug-ping-preview.firebaseapp.com/pings/ad-clicks-dr1
[Glean dashboard] - Beta - https://debug-ping-preview.firebaseapp.com/pings/ad-clickdr2

Note:

• labeled_counter
• browser.search.with_ads -> the number of searches
• browser.search.ad_clicks -> number of clicked ads
• Needs to be taken into consideration that browser.search.with_ads increments each time you are on a page with ads, including when you go back to the same page.

Devices:
Google Pixel 3 XL (Android 9)

Beta Baselines:
6558-Beta - Google Baseline- Search with ads and clicked ads.txt
6558-Beta - Bing Baseline - Search with ads and clicked ads.txt
6558- Beta - Duckduckgo Baseline- Search with ads and clicked ads.txt
6558-Beta - Google,Bing,Duckduckgo Baseline- Search with ads and clicked ads.txt

Example of telemetry:
"labeled_counter": {
"browser.search.ad_clicks": {
"bing": 1,
"duckduckgo": 1,
"google": 1
},
"browser.search.in_content": {
"bing.in-content.sap.mozb": 1,
"duckduckgo.in-content.sap.fpas": 1,
"google.in-content.sap-follow-on.firefox-b-m": 1,
"google.in-content.sap.firefox-b-m": 1
},
"browser.search.with_ads": {
"bing": 1,
"duckduckgo": 1,
"google": 1
},
"metrics.search_count": {
"bing.action": 1,
"google-b-m.action": 1
}

[liuche]

Hi @BranescuMihai ! I was talking to the Glean team, and they were looking at the pings today. They wanted to know if these ad click attribution telemetry needs to be in the Baseline ping (since it is also in the Metrics ping).

I don't remember what the reasons were here for choosing both pings - was there a conversation you had with mconnor or Mike de Boer that we needed to have it in both? Did someone from Data Science need it in both?

If it isn't necessary in both, could you remove it from the baseline ping, and keep it in the metrics ping? (Feel free to ping me for clarification on slack too)

[liuche]

Talked to @BranescuMihai and it sounds like we had some miscommunication very early on about what the baseline vs metrics ping means.

We decided that it makes sense to take these search events out of the baseline ping, and Mihai will open a PR to remove it.

[liuche]

@psymoon filed this issue to track this: #10599 please attach your PR to that issue!