-
Notifications
You must be signed in to change notification settings - Fork 473
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you please just confirm with @mdboom (before merging) that the coarse timing distribution stuff was tested/won't impact GeckoView/GFX metrics?
That mostly adds the missing document begin marker (`---`) and removes some trailing whitespace.
It will change the range of acceptable values on GV metrics at the upper end of the range. This will result in fewer errors when they overflow, and more correct results, and I think this is what we want. At the lower end, incoming milliseconds could never be less than one millisecond anyway, so there is no change. |
Cool, thanks @mdboom - so we don't expect any disruption in things that are already being collected, right? |
Nope. Should be no disruption. It didn't touch the multiplication of values or anything, just increased the maximum. |
bors r=Dexterp37 |
Codecov Report
@@ Coverage Diff @@
## master #6936 +/- ##
============================================
- Coverage 77.06% 76.90% -0.16%
+ Complexity 4836 4665 -171
============================================
Files 650 621 -29
Lines 23806 23055 -751
Branches 3489 3402 -87
============================================
- Hits 18346 17731 -615
+ Misses 4010 3903 -107
+ Partials 1450 1421 -29 Continue to review full report at Codecov.
|
Build succeeded: |
Pull Request checklist
After merge