Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Upgrade Glean to v29.1.0 #6936

Merged
merged 2 commits into from
May 11, 2020
Merged

Upgrade Glean to v29.1.0 #6936

merged 2 commits into from
May 11, 2020

Conversation

badboy
Copy link
Member

@badboy badboy commented May 11, 2020


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@badboy badboy requested a review from Dexterp37 May 11, 2020 11:58
Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you please just confirm with @mdboom (before merging) that the coarse timing distribution stuff was tested/won't impact GeckoView/GFX metrics?

That mostly adds the missing document begin marker (`---`) and removes
some trailing whitespace.
@mdboom
Copy link
Contributor

mdboom commented May 11, 2020

It will change the range of acceptable values on GV metrics at the upper end of the range. This will result in fewer errors when they overflow, and more correct results, and I think this is what we want.

At the lower end, incoming milliseconds could never be less than one millisecond anyway, so there is no change.

@Dexterp37
Copy link
Contributor

It will change the range of acceptable values on GV metrics at the upper end of the range. This will result in fewer errors when they overflow, and more correct results, and I think this is what we want.

At the lower end, incoming milliseconds could never be less than one millisecond anyway, so there is no change.

Cool, thanks @mdboom - so we don't expect any disruption in things that are already being collected, right?

@mdboom
Copy link
Contributor

mdboom commented May 11, 2020

Cool, thanks @mdboom - so we don't expect any disruption in things that are already being collected, right?

Nope. Should be no disruption. It didn't touch the multiplication of values or anything, just increased the maximum.

@Dexterp37
Copy link
Contributor

Cool, thanks @mdboom - so we don't expect any disruption in things that are already being collected, right?

Nope. Should be no disruption. It didn't touch the multiplication of values or anything, just increased the maximum.

Lovely! @badboy let's get this party started then! 🎸

@badboy
Copy link
Member Author

badboy commented May 11, 2020

bors r=Dexterp37

@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #6936 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6936      +/-   ##
============================================
- Coverage     77.06%   76.90%   -0.16%     
+ Complexity     4836     4665     -171     
============================================
  Files           650      621      -29     
  Lines         23806    23055     -751     
  Branches       3489     3402      -87     
============================================
- Hits          18346    17731     -615     
+ Misses         4010     3903     -107     
+ Partials       1450     1421      -29     
Impacted Files Coverage Δ Complexity Δ
...s/lib/push/firebase/AbstractFirebasePushService.kt 69.69% <0.00%> (-3.04%) 9.00% <0.00%> (ø%)
...onents/support/sync/telemetry/BaseGleanSyncPing.kt 100.00% <0.00%> (ø) 11.00% <0.00%> (ø%)
...ort/base/src/main/java/mozilla/components/Build.kt
...s/support/webextensions/facts/WebExtensionFacts.kt
...omponents/feature/accounts/push/SendTabUseCases.kt
...lla/components/support/base/observer/Consumable.kt
...nents/support/webextensions/WebExtensionSupport.kt
...mozilla/components/support/base/android/Padding.kt
...nts/feature/accounts/push/FxaPushSupportFeature.kt
...ava/mozilla/components/support/base/facts/Facts.kt
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a60da6...3212153. Read the comment docs.

@bors
Copy link

bors bot commented May 11, 2020

Build succeeded:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants