Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

UI tests for existing LeanPlum events #11210

Closed
3 tasks
jhugman opened this issue Jun 3, 2020 · 2 comments
Closed
3 tasks

UI tests for existing LeanPlum events #11210

jhugman opened this issue Jun 3, 2020 · 2 comments
Labels

Comments

@jhugman
Copy link
Contributor

jhugman commented Jun 3, 2020

Current manual tests on LeanPlum integration would suggest some events aren't being fired in to the LeanPlum SDK.

It is not always clear that this is a missing work in fenix, bugs in fenix, bugs in the LeanPlum SDK or configuration errors in dashboarding with the marketing team.

In order to ameliorate communication between the mobile engagement team and engineering, such a test would be the final stage of sign-off/confirmation of a new event.

This issue is to come up with tests that can

  • document and test the events that are currently supported.
  • be obviously extendable when new events are added.
  • be impossible to ignore when new events are added.

An end-to-end UI test would be most convincing, but proving just the fenix integration would be a useful place to start:

  • allow for a SpyMetricController to assert that the metrics controller is being called to log the event in existing UI tests.
  • ensure that the Events.name declared in the LeanPlumMetricService logs the correct LeanPlum event name, as agreed with Mobile Engagement team.

Tasks:

  • UI tests showing linkage between the UI events and the event reaching the lean plum SDK
  • those tests being run on CI with the same cadence of other UI tests.
  • a markdown file in the repo specifying when the event is fired and the name of the event.

┆Issue is synchronized with this Jira Task

@liuche
Copy link
Contributor

liuche commented Jul 29, 2020

@jhugman could you summarize what you've tried here? for whoever might need to pick this up.

@data-sync-user data-sync-user changed the title UI tests for existing LeanPlum events FNX3-14474 ⁃ UI tests for existing LeanPlum events Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-14474 ⁃ UI tests for existing LeanPlum events FNX-12092 ⁃ UI tests for existing LeanPlum events Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-12092 ⁃ UI tests for existing LeanPlum events FNX2-13387 ⁃ UI tests for existing LeanPlum events Aug 11, 2020
@kbrosnan kbrosnan changed the title FNX2-13387 ⁃ UI tests for existing LeanPlum events UI tests for existing LeanPlum events Aug 29, 2020
@ekager ekager added Leanplum and removed P1 Current sprint needs:triage Issue needs triage labels Dec 17, 2020
@stale
Copy link

stale bot commented Jun 15, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 15, 2021
@stale stale bot closed this as completed Jun 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants