Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Behaviour when adding a duplicate bookmark #1586

Closed
ekager opened this issue Apr 12, 2019 · 10 comments
Closed

Behaviour when adding a duplicate bookmark #1586

ekager opened this issue Apr 12, 2019 · 10 comments
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Bookmarks

Comments

@ekager
Copy link
Contributor

ekager commented Apr 12, 2019

As a user, I want to see the bookmark edit snackbar if I add a duplicate bookmark, so I can delete it, rename it, or move it to a different location. @topotropic please confirm that I have captured the UX feedback correctly.

Acceptance Criteria:

-I see the edit bookmark snackbar when I add a duplicate bookmark

┆Issue is synchronized with this Jira Task

@colintheshots
Copy link
Contributor

Good question.

@topotropic
Copy link

I can see cases where bookmarking the same site multiple times is ok, for example when people organize content into folders and want the same site in different folders. It's a problem when people are not aware that the site has been bookmarked already though.
This is related #1601 – I think @AmyYLee is going to look into it.

@AmyYLee
Copy link
Collaborator

AmyYLee commented Apr 23, 2019

@ekager @topotropic I added a spec for bookmarked and non-bookmarked states in bug #1601.

@vesta0 vesta0 removed the needs:UX-feedback Needs UX Feedback label Apr 24, 2019
@vesta0 vesta0 added this to the Bugs milestone Apr 24, 2019
@vesta0
Copy link
Collaborator

vesta0 commented Apr 24, 2019

@ekager @AmyYLee in a scenario when user can see that a page has already been bookmarked (#1601) will they still be able to re-bookmark it if they choose to?

@AmyYLee
Copy link
Collaborator

AmyYLee commented Apr 24, 2019

@vesta0 We currently don't offer the ability to have duplicate bookmarks in Fennec. I'm not sure how common the use case would be that the user wants to have multiple instances of a bookmark. Now that we have collections as another ability to save tabs I don't think it's needed but I'll let @topotropic make the final call since she worked on the bookmark flow.

@vesta0
Copy link
Collaborator

vesta0 commented Apr 25, 2019

@AmyYLee that is not what I was asking. I was asking for clarification on the user flow. I saw that you provided specs for bookmarked and non-bookmarked states in #1601. My question is: what happens if a user navigates to a page that's already been bookmarked, sees the bookmarked state of the icon, and still decides to tap on it? Does the bookmark get removed (1), does a second bookmark get added regardless (2), does the user receive a notification indicating that they have already bookmarked that page (3), or does nothing happen (4)?

@topotropic
Copy link

@vesta0 we show the bookmark edit view where they can delete the bookmark, rename it or move it to a different location.

@yoasif
Copy link
Contributor

yoasif commented Apr 25, 2019

@topotropic Elegant solution, and pretty much what happens in Firefox desktop! 😄

@vesta0
Copy link
Collaborator

vesta0 commented Apr 25, 2019

Thanks @topotropic I will create a user story for it.

@vesta0 vesta0 changed the title [Bug] Can add the exact same site to bookmarks many times, duplicates Behaviour when adding a duplicate bookmark Apr 30, 2019
@vesta0 vesta0 added this to High priority backlog in Fenix Sprint Kanban Apr 30, 2019
colintheshots added a commit to colintheshots/fenix that referenced this issue May 1, 2019
colintheshots added a commit to colintheshots/fenix that referenced this issue May 1, 2019
@colintheshots colintheshots self-assigned this May 1, 2019
@colintheshots colintheshots added the eng:qa:needed QA Needed label May 1, 2019
@project-bot project-bot bot moved this from High priority backlog (not in the current sprint) to Ready for QA in Fenix Sprint Kanban May 1, 2019
@colintheshots colintheshots moved this from Ready for QA to In Progress in Fenix Sprint Kanban May 1, 2019
@colintheshots colintheshots moved this from In Progress to Ready for QA in Fenix Sprint Kanban May 1, 2019
@sv-ohorvath
Copy link
Contributor

Verified that now we can't add duplicate bookmarks, just edit the existing ones. Remaining known issue: #2068.

@sv-ohorvath sv-ohorvath added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels May 2, 2019
@sv-ohorvath sv-ohorvath moved this from Ready for QA to Done in Fenix Sprint Kanban May 2, 2019
@bifleming bifleming removed this from Done in Fenix Sprint Kanban May 7, 2019
@data-sync-user data-sync-user changed the title Behaviour when adding a duplicate bookmark FNX2-17240 ⁃ Behaviour when adding a duplicate bookmark Aug 3, 2020
@data-sync-user data-sync-user changed the title FNX2-17240 ⁃ Behaviour when adding a duplicate bookmark FNX3-15664 ⁃ Behaviour when adding a duplicate bookmark Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-15664 ⁃ Behaviour when adding a duplicate bookmark FNX-5119 ⁃ Behaviour when adding a duplicate bookmark Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-5119 ⁃ Behaviour when adding a duplicate bookmark Behaviour when adding a duplicate bookmark May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Bookmarks
Projects
None yet
Development

No branches or pull requests

9 participants