Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] quick action bookmark star should be filled when interacting with the edit snackbar #2068

Closed
kbrosnan opened this issue Apr 26, 2019 · 2 comments
Closed

[Bug] quick action bookmark star should be filled when interacting with the edit snackbar #2068

kbrosnan opened this issue Apr 26, 2019 · 2 comments
Assignees
@ekager
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Bookmarks P1 Current sprint
Milestone
Sprint 5-2 (Miles...

Comments

@kbrosnan
Copy link
Contributor

kbrosnan commented Apr 26, 2019 •
edited by data-sync-user
Loading

Steps to reproduce

  • Open a page
  • Bookmark it
  • Tap Edit in the snackbar
  • Tap the Android Back button
  • Examine the quick action bar

Expected behavior

  • Bookmark created
  • Quick action bar marks the page as bookmarked

Actual behavior

  • Bookmark created
  • Quick action bar marks the page as not bookmarked

Device information

  • Android device: Pixel 3
  • Fenix version: 99f979e

┆Issue is synchronized with this Jira Task
@kbrosnan kbrosnan added 🐞 bug Crashes, Something isn't working, .. Feature:Bookmarks Feature:QuickActionBar labels Apr 26, 2019
@kbrosnan kbrosnan mentioned this issue Apr 26, 2019
Closed
@sv-ohorvath sv-ohorvath mentioned this issue May 2, 2019
Closed
@sv-ohorvath
Copy link
Contributor

The same issue happens if you tap to edit the URL, do nothing, and press the back button to return back to the bookmarked page.

@ekager ekager self-assigned this May 6, 2019
ekager added a commit to ekager/fenix that referenced this issue May 6, 2019
@ekager
For mozilla-mobile#2068 - Create QAS initial state
d50f3fd
colintheshots pushed a commit that referenced this issue May 6, 2019
@ekager @colintheshots
For #2068 - Create QAS initial state (#2298)
e6e3ac3
@vesta0 vesta0 added this to the Sprint 5-1 (Milestone 5) milestone May 6, 2019
@vesta0 vesta0 added the P1 Current sprint label May 6, 2019
@vesta0 vesta0 added this to High priority backlog (not in the current sprint) in Fenix Sprint Kanban May 7, 2019
@ekager ekager added the eng:qa:needed QA Needed label May 13, 2019
@project-bot project-bot bot moved this from High priority backlog (not in the current sprint) to Ready for QA in Fenix Sprint Kanban May 13, 2019
@lobontiumira
Copy link

Verified as fixed with Google Pixel (Android 9), and Sony Xperia Z5 Premium (Android 7.1.1), on the latest build 1.0.1920 (Build#11350639).

@sv-ohorvath sv-ohorvath added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels May 15, 2019
@bsurd bsurd moved this from Ready for QA to Done in Fenix Sprint Kanban May 15, 2019
@data-sync-user data-sync-user changed the title [Bug] quick action bookmark star should be filled when interacting with the edit snackbar FNX2-17638 ⁃ [Bug] quick action bookmark star should be filled when interacting with the edit snackbar Aug 4, 2020
@data-sync-user data-sync-user changed the title FNX2-17638 ⁃ [Bug] quick action bookmark star should be filled when interacting with the edit snackbar FNX3-16036 ⁃ [Bug] quick action bookmark star should be filled when interacting with the edit snackbar Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-16036 ⁃ [Bug] quick action bookmark star should be filled when interacting with the edit snackbar FNX-5435 ⁃ [Bug] quick action bookmark star should be filled when interacting with the edit snackbar Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-5435 ⁃ [Bug] quick action bookmark star should be filled when interacting with the edit snackbar [Bug] quick action bookmark star should be filled when interacting with the edit snackbar May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ekager ekager

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Bookmarks P1 Current sprint
Projects
None yet
Milestone
Sprint 5-2 (Milestone 5)
Development

No branches or pull requests
7 participants
@kbrosnan @sv-ohorvath @ekager @lobontiumira @vesta0 @bifleming @data-sync-user