Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Revise multiselect mode UI #16132

Closed
vesta0 opened this issue Oct 22, 2020 · 3 comments
Closed

Revise multiselect mode UI #16132

vesta0 opened this issue Oct 22, 2020 · 3 comments
Assignees
@ekager
Labels
eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Tabs

Comments

@vesta0
Copy link
Collaborator

vesta0 commented Oct 22, 2020 •
edited by data-sync-user
Loading

Mocks: https://www.figma.com/file/luMaQYjwiMtQM5xQ30P9yP/Tabs?node-id=329%3A489

User Story

  • As a user, I want … so I can do … (keep it problem-centric)

Dependencies

  • List dependencies on other issues/teams etc.

Acceptance Criteria

  • I can do … (e.g. add a bookmark)

┆Issue is synchronized with this Jira Task
@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 22, 2020
@vesta0 vesta0 added Feature:Tabs eng:ready Ready for engineering and removed needs:triage Issue needs triage labels Oct 22, 2020
@Poopooracoocoo Poopooracoocoo mentioned this issue Oct 23, 2020
Closed
@ekager ekager self-assigned this Oct 28, 2020
ekager added a commit to ekager/fenix that referenced this issue Oct 28, 2020
@ekager
For mozilla-mobile#16132 - Revise multiselect mode UI
a62a280
@ekager ekager mentioned this issue Oct 28, 2020
Closed
@Poopooracoocoo Poopooracoocoo mentioned this issue Oct 30, 2020
Closed
ekager added a commit to ekager/fenix that referenced this issue Nov 2, 2020
@ekager
For mozilla-mobile#16132 - Revise multiselect mode UI
e0a7b51
ekager added a commit to ekager/fenix that referenced this issue Nov 3, 2020
@ekager
For mozilla-mobile#16132 - Revise multiselect mode UI
9a95643
@topotropic topotropic mentioned this issue Nov 4, 2020
Closed
ekager added a commit to ekager/fenix that referenced this issue Nov 4, 2020
@ekager
For mozilla-mobile#16132 - Revise multiselect mode UI
fe28337
ekager added a commit to ekager/fenix that referenced this issue Nov 4, 2020
@ekager
For mozilla-mobile#16132 - Revise multiselect mode UI
f047aa3
ekager added a commit to ekager/fenix that referenced this issue Nov 4, 2020
@ekager
For mozilla-mobile#16132 - Revise multiselect mode UI
d92bd42
ekager added a commit to ekager/fenix that referenced this issue Nov 9, 2020
@ekager
For mozilla-mobile#16132 - Revise multiselect mode UI
d55e14d
ekager added a commit to ekager/fenix that referenced this issue Nov 11, 2020
@ekager
For mozilla-mobile#16132 - Revise multiselect mode UI
41951de
ekager added a commit that referenced this issue Nov 11, 2020
@ekager
For #16132 - Revise multiselect mode UI
a8db85f
@ekager ekager added the eng:qa:needed QA Needed label Nov 11, 2020
ekager added a commit to ekager/fenix that referenced this issue Nov 11, 2020
@ekager
For mozilla-mobile#16132 - Rename normal mode menu item, remove telem…
7f3e0a7 
…etry
@ekager
Copy link
Contributor

ekager commented Nov 11, 2020

Shall I open a ticket for new telemetry for these new menu items?

Also one remaining question @topotropic - should multiselect still only be for normal, non-private tabs since we've added more options here?

ekager added a commit to ekager/fenix that referenced this issue Nov 11, 2020
@ekager
For mozilla-mobile#16132 - Rename normal mode menu item, remove telem…
7d2d5e2 
…etry
@topotropic
Copy link

Can you ping me on the telemetry ticket in case you open one? Thanks!

Let's keep it for non-private tabs for now (if feasible – let me know if this adds work). Thanks!

ekager added a commit to ekager/fenix that referenced this issue Nov 11, 2020
@ekager
For mozilla-mobile#16132 - Rename normal mode menu item, remove telem…
8d8c493 
…etry
ekager added a commit to ekager/fenix that referenced this issue Nov 11, 2020
@ekager
For mozilla-mobile#16132 - Rename normal mode menu item, remove telem…
14519f5 
…etry
ekager added a commit that referenced this issue Nov 12, 2020
@ekager
For #16132 - Rename normal mode menu item, remove telemetry
1ed9ebf
@lobontiumira
Copy link

Verified on the 11/16 Nightly build with Samsung Galaxy Tab S6 (Android 10), that the tabs tray has the "Select tabs" button under the opened tabs.
After the "Select tabs" button is tapped, the selection screen displays the new UI:

  • the number of selected tabs,
  • the "save to collection" icon,
  • the "share" icon,
  • the three-dot menu with the "Bookmark", and "Close" options,
  • the opened tabs in list view, or in grid view,
  • the purple checkmark on the selected tab.

selection screen

@lobontiumira lobontiumira removed the eng:qa:needed QA Needed label Nov 16, 2020
@lobontiumira lobontiumira added the eng:qa:verified QA Verified label Nov 16, 2020
@Mugurell Mugurell mentioned this issue Apr 5, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ekager ekager

Labels
eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Tabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@topotropic @ekager @lobontiumira @vesta0