Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Custom Saved Logins Toolbar Header (with chevron filter) has cut off ripple #16271

Closed
ekager opened this issue Oct 29, 2020 · 5 comments
Closed

[Bug] Custom Saved Logins Toolbar Header (with chevron filter) has cut off ripple #16271

ekager opened this issue Oct 29, 2020 · 5 comments
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ux-debt Feature polish and UX engineering debt Feature:Logins help wanted Help wanted from a contributor. More complex than good first issue.

Comments

@ekager
Copy link
Contributor

ekager commented Oct 29, 2020 •
edited by data-sync-user
Loading

Opening from #16219 :
"The ripple background (when clicking the filter button) gets cutoff because of the constraints(?) and lack of padding for it to expand fully" in this file: saved_logins_sort_items_toolbar_child.xml

We should see if it's possible to have the ripple not be cut off here

┆Issue is synchronized with this Jira Task
@ekager ekager added the 🐞 bug Crashes, Something isn't working, .. label Oct 29, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 29, 2020
@gabrielluong gabrielluong added the help wanted Help wanted from a contributor. More complex than good first issue. label Oct 29, 2020
@ekager ekager added eng:ready Ready for engineering and removed needs:triage Issue needs triage labels Oct 29, 2020
shahsurajk added a commit to shahsurajk/fenix that referenced this issue Nov 25, 2020
@shahsurajk
Fixes mozilla-mobile#16271 - Fixes ripple being cut-off in Saved logi…
7b5150b 
…ns sort toolbar
@eliserichards eliserichards mentioned this issue Jan 5, 2021
Merged
3 tasks
bors bot pushed a commit that referenced this issue Jan 5, 2021
@MozLando @shahsurajk
Merge #16741
b1ab6e4 
16741: Fixes #16271 - Fixes ripple being cut-off in Saved logins sort toolbar r=eliserichards a=shahsurajk

For #16271

### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [ ] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [ ] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features. In addition, it includes a screenshot of a successful [accessibility scan](https://play.google.com/store/apps/details?id=com.google.android.apps.accessibility.auditor&hl=en_US) to ensure no new defects are added to the product.

### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

<hr>

@ekager , i'm not sure of the fix. One thing that needs to be carefully reviewed is the height of the toolbar view, i'm explicitly setting it to `?actionbarSize` as we need fixed height to fix this, when using a bordered item drawable. could be wrong here. 🤞

PS: Unable to take screenshot cause of security constraints. 




Co-authored-by: Suraj Shah <shah.suraj.k@gmail.com>
@mcarare mcarare added the eng:qa:needed QA Needed label Jan 6, 2021
gabrielluong pushed a commit that referenced this issue Jan 8, 2021
@shahsurajk
For #16271 - Fixes ripple being cut-off in Saved logins sort toolbar (#…
15f3743 
…16741)
@ebalazs-sv
Copy link

@ekager Hi! Can you please provide the steps to reproduce this issue, so we can verify it? Thank you.
I will keep the qa:needed label to verify this issue when the steps to reproduce are available.

@ebalazs-sv
Copy link

I will remove the qa:needed label until the steps to reproduce are available.

@ebalazs-sv ebalazs-sv removed the eng:qa:needed QA Needed label Jan 13, 2021
@eliserichards eliserichards added Outreachy Feature:Logins eng:ux-debt Feature polish and UX engineering debt and removed eng:ready Ready for engineering labels Apr 20, 2021
@yichiehc
Copy link
Contributor

Hi @eliserichards,

I tried to reproduce this issue but didn't see "the ripple background (when clicking the filter button) gets cut off" on Nightly. Has this been fixed already? Looks like there is a pull request for this? #16741

@eliserichards
Copy link
Contributor

Let's tag QA to verify if this is fixed 👍

@eliserichards eliserichards added the eng:qa:needed QA Needed label Apr 21, 2021
@sflorean
Copy link
Contributor

I didn't see any issues on latest Nightly build with Pixel 3 (Android 11) and LG G7 Fit (Android 8.1).

@sflorean sflorean added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Apr 26, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
@shahsurajk @pkirakosyan
For mozilla-mobile#16271 - Fixes ripple being cut-off in Saved logins…
707eb54 
… sort toolbar (mozilla-mobile#16741)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ux-debt Feature polish and UX engineering debt Feature:Logins help wanted Help wanted from a contributor. More complex than good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@gabrielluong @ekager @eliserichards @yichiehc @ebalazs-sv @mcarare @sflorean