Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #16161 - Fixes Saved Login toolbar layout #16219

Merged
merged 1 commit into from
Oct 29, 2020
Merged

For #16161 - Fixes Saved Login toolbar layout #16219

merged 1 commit into from
Oct 29, 2020

Conversation

ekager
Copy link
Contributor

@ekager ekager commented Oct 27, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@ekager ekager requested review from a team as code owners October 27, 2020 21:46
@mcarare mcarare closed this Oct 28, 2020
@mcarare mcarare reopened this Oct 28, 2020
@gabrielluong gabrielluong added the needs:review PRs that need to be reviewed label Oct 29, 2020
@gabrielluong gabrielluong self-requested a review October 29, 2020 18:46
@gabrielluong gabrielluong self-assigned this Oct 29, 2020
gabrielluong
gabrielluong approved these changes Oct 29, 2020
View reviewed changes
app/src/main/res/layout/saved_logins_sort_items_toolbar_child.xml
<androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
android:id="@+id/sort_logins_menu_root"
android:layout_width="wrap_content"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:background="?android:attr/selectableItemBackgroundBorderless">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will make a note in case this is something we can improve. The ripple background gets cutoff because of the constraints(?) and lack of padding for it to expand fully, but not a blocker

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will file a followup

@gabrielluong gabrielluong added pr:approved PR that has been approved and removed needs:review PRs that need to be reviewed labels Oct 29, 2020
@ekager ekager merged commit 4246293 into mozilla-mobile:master Oct 29, 2020
@ekager ekager deleted the fix-thing branch October 29, 2020 23:10
@ekager ekager mentioned this pull request Oct 29, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gabrielluong gabrielluong gabrielluong approved these changes

Assignees

@gabrielluong gabrielluong

Labels
pr:approved PR that has been approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ekager @gabrielluong @mcarare