This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Fixes #16271 - Fixes ripple being cut-off in Saved logins sort toolbar #16741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns sort toolbar
No Taskcluster jobs started for this pull requestThe `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request. |
|
Hey @shahsurajk! Thanks so much for jumping on this! I'm going to do some manual testing next week to see how this fix is working, and I'll check back in here with a review. Cheers! 🍻 |
|
@Mergifyio refresh |
|
Command
|
|
bors try |
tryBuild succeeded: |
eliserichards
approved these changes
Jan 5, 2021
eliserichards
added
pr:approved
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 5, 2021
16741: Fixes #16271 - Fixes ripple being cut-off in Saved logins sort toolbar r=eliserichards a=shahsurajk For #16271 ### Pull Request checklist <!-- Before submitting the PR, please address each item --> - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not - [ ] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features. In addition, it includes a screenshot of a successful [accessibility scan](https://play.google.com/store/apps/details?id=com.google.android.apps.accessibility.auditor&hl=en_US) to ensure no new defects are added to the product. ### To download an APK when reviewing a PR: 1. click on Show All Checks, 2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark, 3. click on the "Fenix - assemble" task, then click "Run Artifacts". 4. the APK links should be on the left side of the screen, named for each CPU architecture <hr> @ekager , i'm not sure of the fix. One thing that needs to be carefully reviewed is the height of the toolbar view, i'm explicitly setting it to `?actionbarSize` as we need fixed height to fix this, when using a bordered item drawable. could be wrong here. 🤞 PS: Unable to take screenshot cause of security constraints. Co-authored-by: Suraj Shah <shah.suraj.k@gmail.com>
|
@Mergifyio refresh |
|
Command
|
3 tasks
pkirakosyan
pushed a commit
to gexsi/user-agent-android
that referenced
this pull request
Aug 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #16271
Pull Request checklist
To download an APK when reviewing a PR:
@ekager , i'm not sure of the fix. One thing that needs to be carefully reviewed is the height of the toolbar view, i'm explicitly setting it to
?actionbarSizeas we need fixed height to fix this, when using a bordered item drawable. could be wrong here. 🤞PS: Unable to take screenshot cause of security constraints.