Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Fenix Google Search tile [Telemetry] #17418

Closed
7 tasks
lwa-moz opened this issue Jan 12, 2021 · 11 comments
Closed
7 tasks

Fenix Google Search tile [Telemetry] #17418

lwa-moz opened this issue Jan 12, 2021 · 11 comments

Comments

@lwa-moz
Copy link

lwa-moz commented Jan 12, 2021

Description & Product Manager / Data Scientist User Story

Add telemetry to the existing Google search tile that allows for attribution in a similar fashion to the existing telemetry in other search access points, such as the Awesome Bar.

What questions will you answer with this data?

Count of users conducting searches from the Google Search tile.

Acceptance Criteria

  • ENG files a DS JIRA request outlining their methodology.
  • DS sign off on instrumentation methodology addressing product questions.
  • Event pings can be queried via re:dash
  • Event pings can be queried via amplitude
  • We are sending telemetry events for the actions listed in the requirements
  • We have documented the telemetry
  • We have asked a data steward to review the telemetry

┆Issue is synchronized with this Jira Task

@github-actions github-actions bot added the needs:triage Issue needs triage label Jan 12, 2021
@amedyne amedyne removed the needs:triage Issue needs triage label Jan 12, 2021
@amedyne amedyne added this to New Features/Functions (top 20) in Android Team Backlog Staging Board Jan 12, 2021
@amedyne amedyne removed this from New Features/Functions (top 20) in Android Team Backlog Staging Board Jan 14, 2021
@amedyne amedyne added this to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board via automation Jan 14, 2021
@mcarare mcarare closed this as completed Jan 18, 2021
Android Engineering Team Kanban board automation moved this from Ready for Engineering (min-5 ; max-22) to Done Jan 18, 2021
@mcarare mcarare reopened this Jan 18, 2021
Android Engineering Team Kanban board automation moved this from Done to In Development (WIP limit - 15) Jan 18, 2021
@mcarare mcarare moved this from In Development (WIP limit - 15) to Ready for Engineering (min-5 ; max-22) in Android Engineering Team Kanban board Jan 18, 2021
@codrut-topliceanu codrut-topliceanu self-assigned this Jan 19, 2021
@codrut-topliceanu codrut-topliceanu moved this from Ready for Engineering (min-5 ; max-22) to In Development (WIP limit - 15) in Android Engineering Team Kanban board Jan 19, 2021
@codrut-topliceanu
Copy link
Contributor

@lwa-moz Apologies, but could you please provide a bit more info about what you mean when you say "Google search tile"? Do you mean the topSites?

@lwa-moz
Copy link
Author

lwa-moz commented Jan 19, 2021

@lwa-moz Apologies, but could you please provide a bit more info about what you mean when you say "Google search tile"? Do you mean the topSites?

Yes, that's correct. Speaking to this navigational tile in topSites on the Firefox homescreen:
Screenshot_20210119-105835

@codrut-topliceanu
Copy link
Contributor

Sorry to bother you again @lwa-moz , but I'm not entirely sure what you mean by "attribution in a similar fashion to the existing telemetry in other search access points, such as the Awesome Bar." Below I put up a link to all the Awesomebar related metrics I found and all of them seem to be durations.

Would you mind being more specific with the metrics you'd like to see implemented?

perf.awesomebar:

@amedyne amedyne moved this from In Development (WIP limit - 15) to In Tech Design (WIP limit - ?) in Android Engineering Team Kanban board Jan 21, 2021
@mcarare
Copy link
Contributor

mcarare commented Jan 22, 2021

@lwa-moz I am not sure if I am missing some details here, but isn't this the same as Implement top site search engine attribution ?

@gabrielluong
Copy link
Member

I think this is calling for telemetry for the "https://www.google.com" top site, but we should wait for further clarifications. You will see in #17304 that we do an exact string match since the default Google top site can be removed and re-added.

Description & Product Manager / Data Scientist User Story

Add telemetry to the existing Google search tile that allows for attribution in a similar fashion to the existing telemetry in other search access points, such as the Awesome Bar.

I don't know much about the existing telemetry regarding search access points, but it might be good to take a look what is happening there.

@lwa-moz lwa-moz closed this as completed Jan 22, 2021
Android Engineering Team Kanban board automation moved this from In Tech Design (WIP limit - ?) to Done Jan 22, 2021
@lwa-moz lwa-moz reopened this Jan 22, 2021
Android Engineering Team Kanban board automation moved this from Done to In Development (WIP limit - 15) Jan 22, 2021
@lwa-moz
Copy link
Author

lwa-moz commented Jan 22, 2021

Leaving this open to track telemetry related work specifically.

codrut-topliceanu pushed a commit to codrut-topliceanu/fenix that referenced this issue Jan 26, 2021
@codrut-topliceanu codrut-topliceanu moved this from In Development (WIP limit - 15) to Dev Complete (WIP limit - 5) in Android Engineering Team Kanban board Jan 26, 2021
codrut-topliceanu pushed a commit to codrut-topliceanu/fenix that referenced this issue Jan 27, 2021
@eliserichards eliserichards added the needs:data-review PR is awaiting a data review label Jan 27, 2021
@eliserichards eliserichards moved this from Dev Complete (WIP limit - 5) to Review in progress (WIP limit -11) in Android Engineering Team Kanban board Jan 27, 2021
codrut-topliceanu pushed a commit to codrut-topliceanu/fenix that referenced this issue Feb 1, 2021
 ...and implemented it for Google topSite searches.
st3fan pushed a commit that referenced this issue Feb 5, 2021
…17862)

Co-authored-by: codrut.topliceanu <codrut.topliceanu@softvision.ro>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
st3fan pushed a commit that referenced this issue Feb 5, 2021
…17862)

Co-authored-by: codrut.topliceanu <codrut.topliceanu@softvision.ro>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
st3fan added a commit that referenced this issue Feb 8, 2021
…17862) (#17866)

Co-authored-by: codrut.topliceanu <codrut.topliceanu@softvision.ro>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
Co-authored-by: codrut.topliceanu <codrut.topliceanu@softvision.ro>
st3fan added a commit that referenced this issue Feb 8, 2021
…17862) (#17867)

Co-authored-by: codrut.topliceanu <codrut.topliceanu@softvision.ro>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
Co-authored-by: codrut.topliceanu <codrut.topliceanu@softvision.ro>
@lobontiumira
Copy link

lobontiumira commented Feb 9, 2021

Verified in the latest Beta 86.0.0-beta.3, and on the 2/9 Nightly build, with OnePlus 5T (Android 10), that the Google search tile allows for atribution:

{
          "category": "top_sites",
          "name": "open_google_search_attribution",
          "timestamp": 2264
 }

Glean dashboard for Beta
Glean dashboard for Nightly

@lobontiumira
Copy link

Verified also on the latest RC build 85.1.3 with OnePlus 5T (Android 10):

 {
          "category": "top_sites",
          "name": "open_google_search_attribution",
          "timestamp": 3689
        }

Glean dashboard

@lobontiumira lobontiumira added the eng:qa:verified QA Verified label Feb 9, 2021
codrut-topliceanu pushed a commit to codrut-topliceanu/fenix that referenced this issue Feb 10, 2021
This is used to track if the `InContentTelemetry` is a result of the user using the Google Top Site. It looks for `&channel=ts` within the uri.
codrut-topliceanu pushed a commit to codrut-topliceanu/fenix that referenced this issue Feb 10, 2021
codrut-topliceanu pushed a commit to codrut-topliceanu/fenix that referenced this issue Feb 10, 2021
codrut-topliceanu pushed a commit to codrut-topliceanu/fenix that referenced this issue Feb 11, 2021
gabrielluong pushed a commit that referenced this issue Feb 11, 2021
* For #17418 - Adds channel "ts" to TrackKey

This is used to track if the `InContentTelemetry` is a result of the user using the Google Top Site. It looks for `&channel=ts` within the uri.

* For #17418 - Adds TopSite PerformedSearch back in

* For #17418 - Check now looks for equality with GOOGLE_URL

* For #17418 - Adds test for topSite changes
@gabrielluong gabrielluong added eng:qa:needed QA Needed and removed eng:qa:verified QA Verified needs:data-review PR is awaiting a data review labels Feb 11, 2021
@gabrielluong
Copy link
Member

gabrielluong commented Feb 11, 2021

We landed another telemetry in #17637 so I am throwing this back up for qa:needed. This should be similar to #6556 except we are accessing the search access point through the Google Top Site.

@gabrielluong gabrielluong moved this from Review in progress (WIP limit -11) to In Testing/QA in Android Engineering Team Kanban board Feb 11, 2021
@lobontiumira
Copy link

Verified with OnePlus 5T (Android 10) on:

  • 2/12 Nightly build - ping: c6f8ba88-6a58-45ae-8b4a-fb57cde5e17d
{
          "category": "top_sites",
          "name": "open_google_search_attribution",
          "timestamp": 3392
        },
        {
          "category": "events",
          "extra": {
            "source": "shortcut.topsite"
          }

Glean dashboard

On RC 85.1.3, and on Beta 86.0.0-beta.4 the "shortcut.topsite" event isn't triggered.

@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Feb 12, 2021
@gabrielluong gabrielluong moved this from In Testing/QA to Done in Android Engineering Team Kanban board Feb 12, 2021
@gabrielluong
Copy link
Member

Closing since this is now verified.

codrut-topliceanu pushed a commit to codrut-topliceanu/fenix that referenced this issue Feb 15, 2021
st3fan pushed a commit that referenced this issue Feb 16, 2021
* For #17418 - Adds channel "ts" to TrackKey

This is used to track if the `InContentTelemetry` is a result of the user using the Google Top Site. It looks for `&channel=ts` within the uri.

* For #17418 - Adds TopSite PerformedSearch back in

* For #17418 - Check now looks for equality with GOOGLE_URL

* For #17418 - Adds test for topSite changes
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
…p Site click (mozilla-mobile#17862)

Co-authored-by: codrut.topliceanu <codrut.topliceanu@softvision.ro>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
mozilla-mobile#17637)

* For mozilla-mobile#17418 - Adds channel "ts" to TrackKey

This is used to track if the `InContentTelemetry` is a result of the user using the Google Top Site. It looks for `&channel=ts` within the uri.

* For mozilla-mobile#17418 - Adds TopSite PerformedSearch back in

* For mozilla-mobile#17418 - Check now looks for equality with GOOGLE_URL

* For mozilla-mobile#17418 - Adds test for topSite changes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

No branches or pull requests

7 participants