-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #17418 - Add event ping telemetry for the Google Top Site click #17862
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with one question to confirm.
@@ -372,6 +372,10 @@ class DefaultSessionControlController( | |||
TopSite.Type.PINNED -> metrics.track(Event.TopSiteOpenPinned) | |||
} | |||
|
|||
if (url == SupportUtils.GOOGLE_URL) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm - the tile always has GOOGLE_URL and then after the click we determine where it should actually go (GOOGLE_US, GOOGLE_XX) so at this point in thime url
is really always GOOGLE_URL
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will see url = appendSearchAttributionToUrlIfNeeded(url),
on line 384 below.
Codecov Report
@@ Coverage Diff @@
## master #17862 +/- ##
=========================================
Coverage 32.53% 32.54%
Complexity 1324 1324
=========================================
Files 458 458
Lines 19250 19255 +5
Branches 2697 2699 +2
=========================================
+ Hits 6263 6266 +3
- Misses 12471 12473 +2
Partials 516 516
Continue to review full report at Codecov.
|
…p Site click (mozilla-mobile#17862) Co-authored-by: codrut.topliceanu <codrut.topliceanu@softvision.ro> Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
This adds an event ping telemetry for whenever the user clicks and opens a Google top site.
Original data-review @ #17637 (comment)
Pull Request checklist
To download an APK when reviewing a PR: