-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Telemetry counts for Search Access Point #6556
Comments
Hello @liuche, @mconnormoz. I investigated this and saw that we could not reach SAP parity with desktop because atm most of the search entries do not exist on Fenix.
Separated from this, on Fenix we have the search widget which opens the search screen. Is it considered as SAP? |
Thanks for verifying this first piece, that we don't have those Search entry points! The search widget should be included, so please add that SAP telemetry. Thanks for catching that! |
Added two new sources to be counted ('widget' and 'shortcut') besides 'action' and 'suggestion'. Also modified/fixed some tests.
Added two new sources to be counted ('widget' and 'shortcut') besides 'action' and 'suggestion'. Also modified/fixed some tests.
Added two new sources to be counted ('widget' and 'shortcut') besides 'action' and 'suggestion'. Also modified/fixed some tests.
Added two new sources to be counted ('widget' and 'shortcut') besides 'action' and 'suggestion'. Also modified/fixed some tests.
Hi, verified as fixed on ✅ ActionsAction using the default search engine - Ping 216ca0cf-65c3-4829-aea4-bf6ce4e50f65 ✅ SuggestionsSuggestion using the default search engine - Ping 47b8a06f-6dc7-4ff4-b0b5-e91c747fe06a ✅ WidgetAction using the default search engine - Ping 2a23937f-44fb-4889-8f39-0aa6402ee8f3 ✅ Shortcut (Long tap on Fenix from the device's home screen)✔️ Normal browsingAction using the default search engine - Ping 15d31611-ba3f-45ca-bbda-390286f4f970 ✔️ Private browsingAction using the default search engine - Ping 2f0d7284-e1ad-4f00-8d35-142f7eb1f23a ✅ Using the added Private Browsing shortcutAction using the default search engine - Ping 18d279fe-034b-481e-955e-9cfbd36add86 ✅ MetricsMetrics ping containing the search_count totals - Ping dadbeaa7-ec12-42e8-82ff-27cfc56a7c8c
|
Need to verify that we're correctly collecting searches from Fenix's Search Access Points (SAP) (like urlbar, search engine, etc). Here is the list of Desktop's access points to compare to.
Acceptance Criteria
created that is similar to the desktop SEARCH_COUNTS histogram, or a similar data format cleared by Frank Bertsch (Data Engineering)This islabeled_counter
.<engine-name>.<search-access-point>
or<engine-name>.alias
for search shortcutsgoogle-2018.urlbar
recordSearch
implementation┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: