Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug][a11y] Add private shortcut button needs resizing #17904

Closed
sflorean opened this issue Feb 8, 2021 · 16 comments · Fixed by #28056, C-EO/fenix#4, fork-house/fenix#14 or nathanmkaya/fenix#108
Closed

[Bug][a11y] Add private shortcut button needs resizing #17904

sflorean opened this issue Feb 8, 2021 · 16 comments · Fixed by #28056, C-EO/fenix#4, fork-house/fenix#14 or nathanmkaya/fenix#108
Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. 🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:PrivateBrowsing S3 Blocks non-critical functionality and a work around exists
Milestone
109

Comments

@sflorean
Copy link
Contributor

sflorean commented Feb 8, 2021 •
edited by data-sync-user

Prerequisites

Have Google Accessibility Scanner installed.

Steps to reproduce

  1. From the Home screen, tap on the upper right Private Browsing icon and switch to Private Mode. (perform the switch 3 times).
  2. Using the Accessibility Scanner, scan the Add Private Browsing Shortcut to your Home screen contextual recommender.

Expected behavior

The Private Browsing Shortcut recommender is properly scanned and no suggestions are made.

Actual behavior

Screenshot_20210204_164533_com google android apps accessibility auditor

Device information

  • Device vendor / model and Android version: Huawei P40 Lite (Android 11).
  • Firefox for Android version: 86.0.0-beta.2.

┆Issue is synchronized with this Jira Task
@sflorean sflorean added 🐞 bug Crashes, Something isn't working, .. access Accessibility: Talkback, HW keyboard/mouse, braile display etc. Feature:PrivateBrowsing S3 Blocks non-critical functionality and a work around exists labels Feb 8, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 8, 2021
@sflorean sflorean removed the needs:triage Issue needs triage label Feb 8, 2021
fevziomurtekin pushed a commit to fevziomurtekin/fenix that referenced this issue Feb 13, 2021
For issue: mozilla-mobile#17904 Resized to private shortcut button
3163971
fevziomurtekin pushed a commit to fevziomurtekin/fenix that referenced this issue Feb 13, 2021
@fevziomurtekin
For issue: mozilla-mobile#17904 Resized to private shortcut button
9c0a5a8
fevziomurtekin pushed a commit to fevziomurtekin/fenix that referenced this issue Feb 13, 2021
@fevziomurtekin
For issue: mozilla-mobile#17904 Resized to private shortcut button
e74b3da
@eliserichards
Copy link
Contributor

#17985

@liacds
Copy link

liacds commented Mar 30, 2021

can I work on this issue?

@Apurwa96
Copy link

Hi, This is my first time contributing to opensource, let me know if I can work on this.

@DivineUgorji
Copy link

I am an outreachy applicant. Please, I request to be assigned this issue.

@eliserichards
Copy link
Contributor

Hello all! @liacds, are you an Outreachy applicant? If so, since you were the first to comment, you can pick this issue up :)

@liacds
Copy link

liacds commented Mar 30, 2021

@eliserichards Yes, thank you :)

liacds added a commit to liacds/fenix that referenced this issue Mar 31, 2021
@liacds
For mozilla-mobile#17904: resized add shortcut button
c6b25e7
@Mugurell
Copy link
Contributor

Sorry for the mixup @fevziomurtekin. Your PR looked good but looks like another PR was approved and validated by UX in the meantime.
Your contribution would be much appreciated on other tickets like maybe the ones from https://github.com/mozilla-mobile/fenix/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@stale
Copy link

stale bot commented Oct 9, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 9, 2021
@stale stale bot closed this as completed Oct 16, 2021
@LaurentiuApahideanSV
Copy link

The issue still occurs on Firefox Preview 94.0.0-Beta.5.

Device used:

  • Huawei MediaPad M3 (Android 7)

@stale stale bot removed the wontfix label Oct 25, 2021
@LaviniaL99
Copy link

LaviniaL99 commented Dec 22, 2021 •
edited

The issue is still reproducing on Firefox 96.0.0-beta4.
Device model:
Samsung S10e -> Android 10

private shortcut

@lobontiumira
Copy link

Still reproducible on the 105.0b5 Beta build with Samsung Galaxy Note 8 (Android 9).

@AdinaPetridean
Copy link

Still reproducible on the 107.0b1 build with Xiaomi Pad5 (Android 12).

boek added a commit to boek/fenix that referenced this issue Dec 3, 2022
@boek
For mozilla-mobile#17904 - Increases tap area on the add shortcut button
502e1d1
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Dec 3, 2022
@github-actions github-actions bot mentioned this issue Dec 3, 2022
Merged
4 tasks
boek added a commit to boek/fenix that referenced this issue Dec 3, 2022
@boek
For mozilla-mobile#17904 - Increases tap area on the add shortcut button
7bbbafa
boek added a commit to boek/fenix that referenced this issue Dec 5, 2022
@boek
For mozilla-mobile#17904 - Increases tap area on the add shortcut button
930e305
@mergify mergify bot closed this as completed in #28056 Dec 5, 2022
mergify bot pushed a commit that referenced this issue Dec 5, 2022
@boek @mergify
For #17904 - Increases tap area on the add shortcut button
0ea57de
@github-actions github-actions bot reopened this Dec 5, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Dec 5, 2022
@github-actions github-actions bot added this to the 109 milestone Dec 5, 2022
@liacds liacds removed their assignment Dec 6, 2022
@SoftVision-LorandJanos
Copy link

This issue is no longer reproducible on the latest Nightly 109.0a1 (2022-12-07) build.
There is no longer a "Consider making this clickable item larger" suggestion.
Device used: Oppo Find X5 (Android 12).
Closing the ticket as fixed.

Screenshot_2022-12-07-13-43-01-92_80a9469f53bfe75dbc6e8989be28e2f0

@SoftVision-LorandJanos SoftVision-LorandJanos added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Dec 7, 2022
@delia-pop
Copy link

Also verified fixed on Beta 109.0b1 with Lenovo Yoga Tab 11 (Android 11).

This was referenced Jan 15, 2023
Merged
Merged
Merged
@AdinaPetridean
Copy link

This issue is still reproducible on the latest Nightly 111.0a1 from 20/01/2023 and on Firefox 110.0b2 with Nokia 6 (Android 7.1.1).

@jonalmeida
Copy link
Contributor

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1813934

Change performed by the Move to Bugzilla add-on.

JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
@boek @mergify
[fenix] For mozilla-mobilehttps://github.com/mozilla-mobile/fenix/iss…
0c52005 
…ues/17904 - Increases tap area on the add shortcut button
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. 🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:PrivateBrowsing S3 Blocks non-critical functionality and a work around exists
Projects
None yet
Milestone
109