Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For mozilla-mobile#17904 - Increases tap area on the add shortcut button #28056

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

boek
Copy link
Contributor

@boek boek commented Dec 3, 2022

This increases the tap target of the Add Shortcut button without increasing the size of the button.

image

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

  • QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Fixes #17904

@gabrielluong gabrielluong added pr:approved PR that has been approved and removed needs:review PRs that need to be reviewed labels Dec 3, 2022
@mavduevskiy
Copy link
Contributor

@boek
FYI: you could open the details the failed job and restart the failed ones from there

@boek
Copy link
Contributor Author

boek commented Dec 5, 2022

@mavduevskiy great tip! ty!

@boek boek added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Dec 5, 2022
@mergify mergify bot merged commit 0ea57de into mozilla-mobile:main Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:approved PR that has been approved pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][a11y] Add private shortcut button needs resizing
3 participants