Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Saved cards] Display the credit card provider icon #18271

Closed
gabrielluong opened this issue Mar 2, 2021 · 2 comments · Fixed by #19652
Closed

[Saved cards] Display the credit card provider icon #18271

gabrielluong opened this issue Mar 2, 2021 · 2 comments · Fixed by #19652
Assignees
@gabrielluong
Labels
cc-autofill Autofill credit card E1 Estimation Point: trivial, less than half day eng:qa:verified QA Verified Feature:Autofill Address and Credit Card autofill
Milestone
90

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Mar 2, 2021 •
edited by data-sync-user
Loading

This issue is to add the various credit provider icons into Fenix and display them in the "Saved cards" screen. This depends on #18268

Screen Shot 2021-03-02 at 4 20 00 PM

┆Issue is synchronized with this Jira Task
@gabrielluong gabrielluong added E3 Estimation Point: average, 2 - 3 days Feature:Autofill Address and Credit Card autofill cc-autofill Autofill credit card labels Mar 2, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Mar 2, 2021
@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Mar 2, 2021
@gabrielluong gabrielluong changed the title Display the credit card provider icon [Saved cards] Display the credit card provider icon Mar 2, 2021
This was referenced Mar 2, 2021
Closed
Closed
@gabrielluong gabrielluong mentioned this issue Apr 7, 2021
Merged
3 tasks
@gabrielluong gabrielluong added E1 Estimation Point: trivial, less than half day and removed E3 Estimation Point: average, 2 - 3 days labels Apr 14, 2021
@gabrielluong gabrielluong self-assigned this May 19, 2021
@gabrielluong gabrielluong mentioned this issue May 25, 2021
Merged
3 tasks
@gabrielluong gabrielluong added this to the 90 milestone May 26, 2021
gabrielluong added a commit to gabrielluong/fenix that referenced this issue May 26, 2021
@gabrielluong
For mozilla-mobile#18271 - [Saved cards] Display the credit card prov…
074bb71 
…ider icon and report the correct card type
gabrielluong added a commit that referenced this issue May 26, 2021
@gabrielluong
For #18271 - [Saved cards] Display the credit card provider icon and …
c11335f 
…report the correct card type (#19652)
@gabrielluong gabrielluong added the eng:qa:needed QA Needed label May 26, 2021
@abodea
Copy link
Member

abodea commented May 27, 2021 •
edited
Loading

Re-opening as I think it was closed in a PR, until I will verify it.

@abodea abodea reopened this May 27, 2021
@abodea
Copy link
Member

abodea commented May 27, 2021

Verified as fixed on the latest Nightly 5/27 with OnePlus Nord (10).

@abodea abodea closed this as completed May 27, 2021
@abodea abodea added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gabrielluong gabrielluong

Labels
cc-autofill Autofill credit card E1 Estimation Point: trivial, less than half day eng:qa:verified QA Verified Feature:Autofill Address and Credit Card autofill
Projects
None yet
Milestone
90
Development

Successfully merging a pull request may close this issue.

For #18271 - [Saved cards] Display the credit card provider icon gabrielluong/fenix
2 participants
@gabrielluong @abodea