This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For #18271 - [Saved cards] Display the credit card provider icon #19652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielluong
force-pushed
the
18271
branch
3 times, most recently
from
6bf4cc3
to
3c8fa1c
Compare
…ider icon and report the correct card type
jonalmeida
approved these changes
May 26, 2021
|
|
||
| assertTrue(americanExpressCard.validateCreditCardNumber()) | ||
| assertTrue(dinnersClubCard.validateCreditCardNumber()) | ||
| assertTrue(discoverCard.validateCreditCardNumber()) | ||
| assertTrue(jcbCard.validateCreditCardNumber()) | ||
| assertTrue(masterCardCard.validateCreditCardNumber()) | ||
| assertTrue(visaCard.validateCreditCardNumber()) | ||
| assertTrue(voyagerCard.validateCreditCardNumber()) |
There was a problem hiding this comment.
Why did we remove this assertion?
There was a problem hiding this comment.
We don't support voyager in our recognized network so this will always fail.
app/src/test/java/org/mozilla/fenix/settings/creditcards/CreditCardEditorViewTest.kt
Show resolved
Hide resolved
| @@ -22,7 +23,7 @@ class CreditCardEditorStateTest { | |||
| cardNumberLast4 = "1110", | |||
| expiryMonth = 5, | |||
| expiryYear = 2030, | |||
| cardType = "amex", | |||
| cardType = CreditCardNetworkType.AMEX.cardName, | |||
There was a problem hiding this comment.
Leaving a comment here that cardType should really be the enum value. This is something that was discussed on the AC changes as well. The effects of not using that here means that consumers need to constantly convert from a non-type checked value whenever they need to use it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18271
Pull Request checklist
To download an APK when reviewing a PR: