Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Move Tabs Tray to compose: Individual tab viewholders: ListViewHolder. #21894

Closed
Tracked by #21318
amedyne opened this issue Oct 13, 2021 · 2 comments
Closed
Tracked by #21318

Move Tabs Tray to compose: Individual tab viewholders: ListViewHolder. #21894

amedyne opened this issue Oct 13, 2021 · 2 comments
Assignees
@Amejia481

Comments

@amedyne
Copy link
Contributor

amedyne commented Oct 13, 2021 •
edited by data-sync-user

From: #21318

┆Issue is synchronized with this Jira Task
@github-actions github-actions bot added the needs:triage Issue needs triage label Oct 13, 2021
@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Oct 13, 2021
@jonalmeida jonalmeida mentioned this issue Oct 14, 2021
Closed
13 tasks
@Amejia481 Amejia481 self-assigned this Nov 22, 2021
Amejia481 added a commit to Amejia481/fenix that referenced this issue May 9, 2022
@Amejia481
For mozilla-mobile#21894: Move Tabs Tray to compose: Individual tab v…
3eaafd2 
…iewholders: ListViewHolder.
@Amejia481 Amejia481 mentioned this issue May 9, 2022
Closed
Amejia481 added a commit to Amejia481/fenix that referenced this issue May 15, 2022
@Amejia481
For mozilla-mobile#21894: Move Tabs Tray to compose: Individual tab v…
41794da 
…iewholders: ListViewHolder.
Amejia481 added a commit to Amejia481/fenix that referenced this issue May 15, 2022
@Amejia481
For mozilla-mobile#21894: Move Tabs Tray to compose: Individual tab v…
3fc0abc 
…iewholders: ListViewHolder.
Amejia481 added a commit to Amejia481/fenix that referenced this issue May 16, 2022
@Amejia481
For mozilla-mobile#21894: Move Tabs Tray to compose: Individual tab v…
d376187 
…iewholders: ListViewHolder.
Amejia481 added a commit to Amejia481/fenix that referenced this issue May 16, 2022
@Amejia481
For mozilla-mobile#21894: Move Tabs Tray to compose: Individual tab v…
c1826a8 
…iewholders: ListViewHolder.
Amejia481 added a commit to Amejia481/fenix that referenced this issue May 17, 2022
@Amejia481
For mozilla-mobile#21894: Move Tabs Tray to compose: Individual tab v…
4feaf40 
…iewholders: ListViewHolder.
Amejia481 added a commit to Amejia481/fenix that referenced this issue May 18, 2022
@Amejia481
For mozilla-mobile#21894: Move Tabs Tray to compose: Individual tab v…
35bf2d1 
…iewholders: ListViewHolder.
Amejia481 added a commit to Amejia481/fenix that referenced this issue May 19, 2022
@Amejia481
For mozilla-mobile#21894: Move Tabs Tray to compose: Individual tab v…
9ed8ba8 
…iewholders: ListViewHolder.
Amejia481 added a commit to Amejia481/fenix that referenced this issue May 19, 2022
@Amejia481
For mozilla-mobile#21894: Move Tabs Tray to compose: Individual tab v…
0f27195 
…iewholders: ListViewHolder.
Amejia481 added a commit to Amejia481/fenix that referenced this issue May 19, 2022
@Amejia481
For mozilla-mobile#21894: Move Tabs Tray to compose: Individual tab v…
e85eedd 
…iewholders: ListViewHolder.
Amejia481 added a commit to Amejia481/fenix that referenced this issue May 19, 2022
@Amejia481
For mozilla-mobile#21894: Move Tabs Tray to compose: Individual tab v…
4857218 
…iewholders: ListViewHolder.
Amejia481 added a commit to Amejia481/fenix that referenced this issue May 30, 2022
@Amejia481
For mozilla-mobile#21894: Move Tabs Tray to compose: Individual tab v…
b478433 
…iewholders: ListViewHolder.
Amejia481 added a commit to Amejia481/fenix that referenced this issue Jun 27, 2022
@Amejia481
For mozilla-mobile#21894: Move Tabs Tray to compose: Individual tab v…
fc024ce 
…iewholders: ListViewHolder.
Amejia481 added a commit to Amejia481/fenix that referenced this issue Jun 27, 2022
@Amejia481
For mozilla-mobile#21894: Move Tabs Tray to compose: Individual tab v…
50e4553 
…iewholders: ListViewHolder.
mergify bot pushed a commit that referenced this issue Jun 27, 2022
@Amejia481 @mergify
For #21894: Move Tabs Tray to compose: Individual tab viewholders: Li…
5f14484 
…stViewHolder.
@MozillaNoah
Copy link
Contributor

@Amejia481, I noticed this issue wasn't flagged and auto closed with your PR the other day. Should this be closed or did it need to be formally QA'd?

@Amejia481
Copy link
Contributor

Yes, I think we could close it. As at the moment it's behind a feature flag that it's only active on debug builds. Ideally we would like to active it on nightly for people to provide feedback, but not sure if we should as we we don't have support for tabs re-ordering in compose yet.

@Amejia481 Amejia481 changed the title Move Tabs Tray to compose: Individual tab viewholders: GridViewHolder, ListViewHolder. Move Tabs Tray to compose: Individual tab viewholders: ListViewHolder. Jul 5, 2022
@Amejia481 Amejia481 mentioned this issue Jul 5, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Amejia481 Amejia481

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Amejia481 @gabrielluong @amedyne @MozillaNoah