-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[build] compileKotlin task gets invalidated between builds #22569
Comments
One scenario when this happens:
You'd expect the second
I think that's happening due to how we configure the Removing this condition and always applying this plugin solves this particular problem. Vice versa, re-adding the condition after a clean So, why was this plugin only enabled for I guess having this Also, I don't think we really need this
For now, I think the simplest thing is to remove the plugin entirely, mark a few classes as This will remove compiler plugin magic, simplify things a bit and speed up our local builds. Kind of off-topic, but for some reason I don't quite understand there's a bit of an indirection in how we have these annotation classes setup - in https://github.com/mozilla-mobile/fenix/blob/main/app/src/main/java/org/mozilla/fenix/utils/OpenClass.kt we have two annotations defined, Also, note that comments in |
Fixing this |
This was addressed in #22601 |
To close the loop here - I ended up removing The only class I ended up marking as |
This causes unnecessary, (nearly?) full rebuilds. E.g. sometimes running an
assembleDebug
task, and then running it a few minutes later without any changes will perform a lengthy rebuild.Same issue seems to affects tests - re-running unit tests in Fenix (without any code changes) seems to actually re-run them.
The problem appears intermittent - it doesn't always happen, but happens enough to be fairly easily noticeable locally. Also, doesn't appear new.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: