-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Migrate CollectionViewHolder to Compose #24333
Comments
Migrating this to compose allows us to also simplify the current approach of adding having collections and collection items as separate viewholders on screen. ( Since a collection contains a list of tabs the migrated to compose CollectionsIssues.mp4 |
I would prefer to see the migration to use a This is not to say we shouldn't convert everything to Compose, but to do it in reasonable steps so we can review the code more easily and evaluate the risk. |
Doing just a file move in a separate commit will ensure git history of the file is kept when this will be later updated.
After migrating to compose identifying widgets and interacting with them will need to be updated. Checked with Oana about the approach, commenting the code seems better.
@ QA: This was migrated to Compose but should look and behave the same as before. |
Verified as fixed with the latest Nightly 102.0a1 (2022-05-18T17:12:12.001240). Samsung Galaxy Tab S3 (Android 9). |
Breakage of #22755
This refers to:
The compose versions can be added to the current RecyclerView but before doing so we should ensure there will be no performance regression introduced.
To profile the differences the steps from #21854 (comment) can be used.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: