Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #25044 - Remove the broken code for focusing the newly created collection #25045

Merged
merged 1 commit into from
May 2, 2022
Merged

For #25044 - Remove the broken code for focusing the newly created collection #25045

merged 1 commit into from
May 2, 2022

Conversation

gabrielluong
Copy link
Member

This functionality seems broken for a long time now.
It's importance and whether to reimplement it is to be re-assessed in
#24389

Fixes #25044

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@gabrielluong gabrielluong requested review from a team as code owners April 30, 2022 15:28
@gabrielluong gabrielluong added the needs:review PRs that need to be reviewed label May 2, 2022
@gabrielluong gabrielluong added pr:approved PR that has been approved and removed needs:review PRs that need to be reviewed labels May 2, 2022
@Mugurell @gabrielluong
For mozilla-mobile#25044 - Remove the broken code for focusing the ne…
d3cc9c5 
…wly created collection

This functionality seems broken for a long time now.
It's importance and whether to reimplement it is to be re-assessed in
mozilla-mobile#24389
@gabrielluong gabrielluong added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label May 2, 2022
@mergify mergify bot merged commit 8b56a2e into mozilla-mobile:main May 2, 2022
@gabrielluong gabrielluong deleted the 25044 branch May 2, 2022 23:21
@Mugurell Mugurell mentioned this pull request May 5, 2022
Merged
3 tasks
mergify bot pushed a commit that referenced this pull request May 11, 2022
@Mugurell @mergify
For #24333 - Complete removing the broken code for focusing the newly…
aeb45c0 
… created collection

The removal was initially scheduled to happen in the PR for #24333
but landed separately in #25045.
These are two small leftovers.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MozillaNoah MozillaNoah MozillaNoah approved these changes

Assignees
No one assigned
Labels
pr:approved PR that has been approved pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the broken code for focusing the newly created collection
3 participants
@gabrielluong @MozillaNoah @Mugurell