Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Newly created collections are not highlighted #24389

Closed
Mugurell opened this issue Mar 22, 2022 · 2 comments
Closed

Newly created collections are not highlighted #24389

Mugurell opened this issue Mar 22, 2022 · 2 comments
Labels
Feature:Collections Feature:HomeScreen needs:UX-feedback Needs UX Feedback pin Issues, features, improvements that are still valid

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Mar 22, 2022

Creating a new collection from tabs tray and pressing "View" in the snackbar should scroll to and focus to the newly created collection while also animating a border around it, something implemented in #2899.

Seems like this functionality has been broken for a while because it was based on a hardcoded number of homescreen sections above collections and there have been many updates to these sections including an option to enabled or disable them which would've affect the functionality.

The old functionality can still be seen if disabling all homescreen sections above collections:

Animating.collections.mp4

 

Since this isn't working for quite some time maybe the homescreen migration to compose is the right time to assess whether this functionality is needed and should be migrated or not.
@topotropic @kbrosnan

┆Issue is synchronized with this Jira Task

@github-actions github-actions bot added the needs:triage Issue needs triage label Mar 22, 2022
@amedyne amedyne removed the needs:triage Issue needs triage label Mar 28, 2022
gabrielluong pushed a commit to gabrielluong/fenix that referenced this issue Apr 30, 2022
…wly created collection

This functionality seems broken for a long time now.
It's importance and whether to reimplement it is to be re-assessed in
mozilla-mobile#24389
gabrielluong pushed a commit to gabrielluong/fenix that referenced this issue Apr 30, 2022
…wly created collection

This functionality seems broken for a long time now.
It's importance and whether to reimplement it is to be re-assessed in
mozilla-mobile#24389
gabrielluong pushed a commit to gabrielluong/fenix that referenced this issue May 2, 2022
…wly created collection

This functionality seems broken for a long time now.
It's importance and whether to reimplement it is to be re-assessed in
mozilla-mobile#24389
mergify bot pushed a commit that referenced this issue May 2, 2022
…llection

This functionality seems broken for a long time now.
It's importance and whether to reimplement it is to be re-assessed in
#24389
@stale
Copy link

stale bot commented Nov 19, 2022

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 19, 2022
@Mugurell Mugurell added the pin Issues, features, improvements that are still valid label Nov 21, 2022
@stale stale bot removed the wontfix label Nov 21, 2022
@cpeterso
Copy link

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1809827

Change performed by the Move to Bugzilla add-on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature:Collections Feature:HomeScreen needs:UX-feedback Needs UX Feedback pin Issues, features, improvements that are still valid
Projects
None yet
Development

No branches or pull requests

3 participants