Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Crash when using custom tab back button #2447

Closed
bsurd opened this issue May 13, 2019 · 2 comments
Closed

[Bug] Crash when using custom tab back button #2447

bsurd opened this issue May 13, 2019 · 2 comments
Labels
b:crash Crashes Fenix: should link to Sentry, Crash-Stats or GPlay info 🐞 bug Crashes, Something isn't working, ..

Comments

@bsurd
Copy link

bsurd commented May 13, 2019

Steps to reproduce

  1. Open a custom tab.
  2. Press the back button.

Expected behavior

You are taken to the previous app from where the custom tab was opened.

Actual behavior

The app crashes.

Device information

┆Issue is synchronized with this Jira Task

@bsurd bsurd added 🐞 bug Crashes, Something isn't working, .. b:crash Crashes Fenix: should link to Sentry, Crash-Stats or GPlay info labels May 13, 2019
@cadeyrn
Copy link
Contributor

cadeyrn commented May 13, 2019

Exception:

2019-05-13 20:55:45.320 6981-6981/org.mozilla.fenix.debug E/AndroidRuntime: FATAL EXCEPTION: main
    Process: org.mozilla.fenix.debug, PID: 6981
    java.lang.RuntimeException: Unable to stop activity {org.mozilla.fenix.debug/org.mozilla.fenix.customtabs.CustomTabActivity}: java.lang.IllegalArgumentException: Required value was null.
        at android.app.ActivityThread.performDestroyActivity(ActivityThread.java:4670)
        at android.app.ActivityThread.handleDestroyActivity(ActivityThread.java:4737)
        at android.app.ActivityThread.-wrap5(Unknown Source:0)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1710)
        at android.os.Handler.dispatchMessage(Handler.java:105)
        at android.os.Looper.loop(Looper.java:180)
        at android.app.ActivityThread.main(ActivityThread.java:6950)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:835)
     Caused by: java.lang.IllegalArgumentException: Required value was null.
        at org.mozilla.fenix.browser.BrowserFragment.getSessionById(BrowserFragment.kt:689)
        at org.mozilla.fenix.browser.BrowserFragment.onStop(BrowserFragment.kt:509)
        at androidx.fragment.app.Fragment.performStop(Fragment.java:2836)
        at androidx.fragment.app.FragmentManagerImpl.moveToState(FragmentManagerImpl.java:933)
        at androidx.fragment.app.FragmentManagerImpl.moveFragmentToExpectedState(FragmentManagerImpl.java:1228)
        at androidx.fragment.app.FragmentManagerImpl.moveToState(FragmentManagerImpl.java:1293)
        at androidx.fragment.app.FragmentManagerImpl.dispatchStateChange(FragmentManagerImpl.java:2646)
        at androidx.fragment.app.FragmentManagerImpl.dispatchStop(FragmentManagerImpl.java:2621)
        at androidx.fragment.app.Fragment.performStop(Fragment.java:2832)
        at androidx.fragment.app.FragmentManagerImpl.moveToState(FragmentManagerImpl.java:933)
        at androidx.fragment.app.FragmentManagerImpl.moveFragmentToExpectedState(FragmentManagerImpl.java:1228)
        at androidx.fragment.app.FragmentManagerImpl.moveToState(FragmentManagerImpl.java:1293)
        at androidx.fragment.app.FragmentManagerImpl.dispatchStateChange(FragmentManagerImpl.java:2646)
        at androidx.fragment.app.FragmentManagerImpl.dispatchStop(FragmentManagerImpl.java:2621)
        at androidx.fragment.app.FragmentController.dispatchStop(FragmentController.java:290)
        at androidx.fragment.app.FragmentActivity.onStop(FragmentActivity.java:564)
        at androidx.appcompat.app.AppCompatActivity.onStop(AppCompatActivity.java:207)
        at android.app.Instrumentation.callActivityOnStop(Instrumentation.java:1454)
        at android.app.Activity.performStop(Activity.java:7161)

@lobontiumira
Copy link

Closing this as a dupe of #2414

@data-sync-user data-sync-user changed the title [Bug] Crash when using custom tab back button FNX2-18006 ⁃ [Bug] Crash when using custom tab back button Aug 5, 2020
@data-sync-user data-sync-user changed the title FNX2-18006 ⁃ [Bug] Crash when using custom tab back button FNX3-16332 ⁃ [Bug] Crash when using custom tab back button Aug 11, 2020
@kbrosnan kbrosnan changed the title FNX3-16332 ⁃ [Bug] Crash when using custom tab back button [Bug] Crash when using custom tab back button Aug 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
b:crash Crashes Fenix: should link to Sentry, Crash-Stats or GPlay info 🐞 bug Crashes, Something isn't working, ..
Projects
None yet
Development

No branches or pull requests

5 participants