Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Only promotion wallpapers should be locale-restricted. #24929

Closed
MatthewTighe opened this issue Apr 22, 2022 · 0 comments
Closed

Only promotion wallpapers should be locale-restricted. #24929

MatthewTighe opened this issue Apr 22, 2022 · 0 comments
Assignees
@MatthewTighe
Labels
Feature:Wallpapers needs:triage Issue needs triage

Comments

@MatthewTighe
Copy link
Contributor

MatthewTighe commented Apr 22, 2022 •
edited by data-sync-user
Loading

There were two Firefox wallpapers recently added to the remote wallpaper list. Unlike the promotional offerings, these wallpapers should not be locale-restricted. All downloaded wallpapers are currently hidden behind the same locale flag.

  • Remove the restriction for the Firefox wallpapers.
  • Promotional wallpapers should still be locale-restricted.

┆Issue is synchronized with this Jira Task
@MatthewTighe MatthewTighe self-assigned this Apr 22, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 22, 2022
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Apr 22, 2022
@MatthewTighe
for mozilla-mobile#24929: remove locale restriction for remote firefo…
108b96b 
…x wallpapers
@MatthewTighe MatthewTighe mentioned this issue Apr 22, 2022
Merged
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Apr 22, 2022
@MatthewTighe
for mozilla-mobile#24929: remove locale restriction for remote firefo…
7549e42 
…x wallpapers
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Apr 22, 2022
@MatthewTighe
for mozilla-mobile#24929: remove locale restriction for remote firefo…
665e5e4 
…x wallpapers
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Apr 22, 2022
@MatthewTighe
for mozilla-mobile#24929: remove locale restriction for remote firefo…
43f5720 
…x wallpapers
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Apr 22, 2022
@MatthewTighe
for mozilla-mobile#24929: remove locale restriction for remote firefo…
6dde8e2 
…x wallpapers
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Apr 22, 2022
@MatthewTighe
for mozilla-mobile#24929: remove locale restriction for remote firefo…
6fe6373 
…x wallpapers
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Apr 22, 2022
@MatthewTighe
for mozilla-mobile#24929: remove locale restriction for remote firefo…
ecdb3ee 
…x wallpapers
mergify bot pushed a commit that referenced this issue Apr 22, 2022
@MatthewTighe @mergify
for #24929: remove locale restriction for remote firefox wallpapers
0f95228
mergify bot pushed a commit that referenced this issue Apr 22, 2022
@MatthewTighe
for #24929: remove locale restriction for remote firefox wallpapers
83a6b6b 
(cherry picked from commit 0f95228)
MatthewTighe added a commit that referenced this issue Apr 23, 2022
@mergify @MatthewTighe
for #24929: remove locale restriction for remote firefox wallpapers (#…
f884a4c 
…24938)

(cherry picked from commit 0f95228)

Co-authored-by: MatthewTighe <mtighe@mozilla.com>
lillabldv added a commit to karmaSearch/fenix that referenced this issue Jun 11, 2022
@lillabldv
Merge commit '827b01341f76e9ee8c152260992eb5f22a775791' into merge/100.3
36f61c1 
* commit '827b01341f76e9ee8c152260992eb5f22a775791': (792 commits)
  Automatic version bump CLOSED TREE NO BUG a=release
  Update to Android-Components 100.0.12. (mozilla-mobile#25307)
  Bump version to 100.3.0
  Automatic version bump CLOSED TREE NO BUG a=release
  Bump version to 100.2.0
  Automatic version bump CLOSED TREE NO BUG a=release
  Update to Android-Components 100.0.11. (mozilla-mobile#25235)
  For mozilla-mobile#25187: Dismiss the default browser card after clicking.
  Automatic version bump CLOSED TREE NO BUG a=release
  Set default browser banner location to homescreen-banner
  Automatic version bump CLOSED TREE NO BUG a=release
  Update to Android-Components 100.0.10. (mozilla-mobile#25023)
  Automatic version bump CLOSED TREE NO BUG a=release
  Update to Android-Components 100.0.9. (mozilla-mobile#24956)
  Bump version to 100.1.0
  Strings - app/src/main/res/values-tg/strings.xml
  Strings - app/src/main/res/values-oc/strings.xml
  for mozilla-mobile#24929: remove locale restriction for remote firefox wallpapers (mozilla-mobile#24938)
  Strings - app/src/main/res/values-sl/strings.xml
  Strings - app/src/main/res/values-ja/strings.xml
  ...

# Conflicts:
#	app/build.gradle
#	app/metrics.yaml
#	app/src/androidTest/java/org/mozilla/fenix/ui/SettingsBasicsTest.kt
#	app/src/androidTest/java/org/mozilla/fenix/ui/SmokeTest.kt
#	app/src/androidTest/java/org/mozilla/fenix/ui/robots/HomeScreenRobot.kt
#	app/src/main/java/org/mozilla/fenix/FeatureFlags.kt
#	app/src/main/java/org/mozilla/fenix/FenixApplication.kt
#	app/src/main/java/org/mozilla/fenix/HomeActivity.kt
#	app/src/main/java/org/mozilla/fenix/addons/AddonsManagementFragment.kt
#	app/src/main/java/org/mozilla/fenix/components/Core.kt
#	app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarView.kt
#	app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt
#	app/src/main/java/org/mozilla/fenix/experiments/NimbusFeatures.kt
#	app/src/main/java/org/mozilla/fenix/ext/String.kt
#	app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt
#	app/src/main/java/org/mozilla/fenix/home/HomeFragmentStore.kt
#	app/src/main/java/org/mozilla/fenix/home/HomeMenu.kt
#	app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlAdapter.kt
#	app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlInteractor.kt
#	app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlView.kt
#	app/src/main/java/org/mozilla/fenix/home/topsites/TopSiteItemViewHolder.kt
#	app/src/main/java/org/mozilla/fenix/search/toolbar/ToolbarView.kt
#	app/src/main/java/org/mozilla/fenix/settings/HomeSettingsFragment.kt
#	app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt
#	app/src/main/java/org/mozilla/fenix/share/ShareViewModel.kt
#	app/src/main/java/org/mozilla/fenix/tabstray/FloatingActionButtonBinding.kt
#	app/src/main/java/org/mozilla/fenix/tabstray/TabLayoutMediator.kt
#	app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayInactiveTabsOnboardingBinding.kt
#	app/src/main/java/org/mozilla/fenix/tabstray/TabsTrayMenu.kt
#	app/src/main/java/org/mozilla/fenix/tabstray/TrayPagerAdapter.kt
#	app/src/main/java/org/mozilla/fenix/theme/FirefoxTheme.kt
#	app/src/main/java/org/mozilla/fenix/utils/Settings.kt
#	app/src/main/res/color/toggle_text_color.xml
#	app/src/main/res/drawable/button_background.xml
#	app/src/main/res/drawable/home_search_background.xml
#	app/src/main/res/drawable/ic_desktop.xml
#	app/src/main/res/drawable/ic_download.xml
#	app/src/main/res/drawable/ic_history.xml
#	app/src/main/res/drawable/ic_search.xml
#	app/src/main/res/drawable/onboarding_popup_shape.xml
#	app/src/main/res/layout/activity_migration.xml
#	app/src/main/res/layout/component_collection_creation.xml
#	app/src/main/res/layout/component_tracking_protection_panel.xml
#	app/src/main/res/layout/fragment_home.xml
#	app/src/main/res/layout/mp_migration_dialog.xml
#	app/src/main/res/layout/mp_migration_done_dialog.xml
#	app/src/main/res/layout/onboarding_inactive_tabs_cfr.xml
#	app/src/main/res/layout/onboarding_jump_back_in_cfr.xml
#	app/src/main/res/layout/search_widget_extra_small_v1.xml
#	app/src/main/res/layout/search_widget_large.xml
#	app/src/main/res/layout/search_widget_small.xml
#	app/src/main/res/layout/share_tab_item.xml
#	app/src/main/res/values-br/strings.xml
#	app/src/main/res/values-cy/strings.xml
#	app/src/main/res/values-de/strings.xml
#	app/src/main/res/values-dsb/strings.xml
#	app/src/main/res/values-el/strings.xml
#	app/src/main/res/values-en-rCA/strings.xml
#	app/src/main/res/values-en-rGB/strings.xml
#	app/src/main/res/values-eo/strings.xml
#	app/src/main/res/values-es-rAR/strings.xml
#	app/src/main/res/values-es-rCL/strings.xml
#	app/src/main/res/values-es-rMX/strings.xml
#	app/src/main/res/values-et/strings.xml
#	app/src/main/res/values-eu/strings.xml
#	app/src/main/res/values-fi/strings.xml
#	app/src/main/res/values-fr/strings.xml
#	app/src/main/res/values-fy-rNL/strings.xml
#	app/src/main/res/values-gl/strings.xml
#	app/src/main/res/values-hsb/strings.xml
#	app/src/main/res/values-hu/strings.xml
#	app/src/main/res/values-hy-rAM/strings.xml
#	app/src/main/res/values-ia/strings.xml
#	app/src/main/res/values-in/strings.xml
#	app/src/main/res/values-it/strings.xml
#	app/src/main/res/values-iw/strings.xml
#	app/src/main/res/values-ja/strings.xml
#	app/src/main/res/values-ka/strings.xml
#	app/src/main/res/values-kab/strings.xml
#	app/src/main/res/values-kk/strings.xml
#	app/src/main/res/values-ko/strings.xml
#	app/src/main/res/values-lt/strings.xml
#	app/src/main/res/values-my/strings.xml
#	app/src/main/res/values-night/colors.xml
#	app/src/main/res/values-nl/strings.xml
#	app/src/main/res/values-nn-rNO/strings.xml
#	app/src/main/res/values-oc/strings.xml
#	app/src/main/res/values-pa-rIN/strings.xml
#	app/src/main/res/values-pl/strings.xml
#	app/src/main/res/values-pt-rBR/strings.xml
#	app/src/main/res/values-rm/strings.xml
#	app/src/main/res/values-ru/strings.xml
#	app/src/main/res/values-sat/strings.xml
#	app/src/main/res/values-sk/strings.xml
#	app/src/main/res/values-sl/strings.xml
#	app/src/main/res/values-sv-rSE/strings.xml
#	app/src/main/res/values-ta/strings.xml
#	app/src/main/res/values-tg/strings.xml
#	app/src/main/res/values-tr/strings.xml
#	app/src/main/res/values-trs/strings.xml
#	app/src/main/res/values-uk/strings.xml
#	app/src/main/res/values-vi/strings.xml
#	app/src/main/res/values-zh-rCN/strings.xml
#	app/src/main/res/values-zh-rTW/strings.xml
#	app/src/main/res/values/attrs.xml
#	app/src/main/res/values/colors.xml
#	app/src/main/res/values/dimens.xml
#	app/src/main/res/values/preference_keys.xml
#	app/src/main/res/values/static_strings.xml
#	app/src/main/res/values/strings.xml
#	app/src/main/res/values/styles.xml
#	app/src/release/res/values/colors.xml
#	app/src/test/java/org/mozilla/fenix/home/SessionControlInteractorTest.kt
#	app/src/test/java/org/mozilla/fenix/home/sessioncontrol/SessionControlViewTest.kt
#	app/src/test/java/org/mozilla/fenix/share/ShareViewModelTest.kt
#	buildSrc/src/main/java/AndroidComponents.kt
#	buildSrc/src/main/java/Dependencies.kt
#	version.txt
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MatthewTighe MatthewTighe

Labels
Feature:Wallpapers needs:triage Issue needs triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MatthewTighe