Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Refactor InactiveTabs' interactors #25491

Closed
MozillaNoah opened this issue Jun 1, 2022 · 0 comments · Fixed by #25636
Closed

Refactor InactiveTabs' interactors #25491

MozillaNoah opened this issue Jun 1, 2022 · 0 comments · Fixed by #25636
Assignees
@MozillaNoah
Labels
eng:health Improve code health Feature:InactiveTabs Tabs in the tabs tray that have not been used in some time.

Comments

@MozillaNoah
Copy link
Contributor

MozillaNoah commented Jun 1, 2022 •
edited by data-sync-user

Per #24735 (comment) and #24735 (comment), the Inactive Tabs controllers need to be refactored:

  • The delete all functionality should live within the InactiveTabsInteractor call stack and not TabsTrayInteractor
  • InactiveTabsController should instead have a InactiveTabsController interface and a DefaultInactiveTabsController implementor
  • The calls to BrowserTrayInteractor should be put into InactiveTabsInteractor

┆Issue is synchronized with this Jira Task
@MozillaNoah MozillaNoah added eng:health Improve code health Feature:InactiveTabs Tabs in the tabs tray that have not been used in some time. labels Jun 1, 2022
@MozillaNoah MozillaNoah self-assigned this Jun 1, 2022
@MozillaNoah MozillaNoah mentioned this issue Jun 1, 2022
Merged
3 tasks
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 1, 2022
@MozillaNoah MozillaNoah changed the title Refactor Inactive Refactor InactiveTabs' interactors Jun 2, 2022
@MozillaNoah MozillaNoah removed the needs:triage Issue needs triage label Jun 8, 2022
@MozillaNoah MozillaNoah mentioned this issue Jun 15, 2022
Merged
3 tasks
@mergify mergify bot closed this as completed in #25636 Jun 22, 2022
mergify bot pushed a commit that referenced this issue Jun 22, 2022
@MozillaNoah @mergify
For #25491 - Refactor InactiveTabs interactors and controllers
5f7fd53
@github-actions github-actions bot mentioned this issue Jul 19, 2022
Closed
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MozillaNoah MozillaNoah

Labels
eng:health Improve code health Feature:InactiveTabs Tabs in the tabs tray that have not been used in some time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

For #25491 - Refactor InactiveTabs interactors and controllers MozillaNoah/fenix
1 participant
@MozillaNoah