Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #25491 - Refactor InactiveTabs interactors and controllers #25636

Merged
merged 2 commits into from
Jun 22, 2022
Merged

For #25491 - Refactor InactiveTabs interactors and controllers #25636

merged 2 commits into from
Jun 22, 2022

Conversation

MozillaNoah
Copy link
Contributor

@MozillaNoah MozillaNoah commented Jun 15, 2022 •
edited
Loading

Closes #25491

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@MozillaNoah MozillaNoah added the pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on label Jun 15, 2022
@MozillaNoah MozillaNoah added needs:review PRs that need to be reviewed and removed pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on labels Jun 21, 2022
@MozillaNoah MozillaNoah marked this pull request as ready for review June 21, 2022 20:51
@MozillaNoah MozillaNoah requested review from a team as code owners June 21, 2022 20:51
@gabrielluong gabrielluong added pr:approved PR that has been approved and removed needs:review PRs that need to be reviewed labels Jun 22, 2022
@MozillaNoah MozillaNoah added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Jun 22, 2022
@mergify mergify bot merged commit 5f7fd53 into mozilla-mobile:main Jun 22, 2022
@MozillaNoah MozillaNoah mentioned this pull request Jun 22, 2022
Closed
13 tasks
This was referenced Dec 20, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gabrielluong gabrielluong gabrielluong approved these changes

Assignees
No one assigned
Labels
pr:approved PR that has been approved pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor InactiveTabs' interactors
2 participants
@MozillaNoah @gabrielluong