Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Create a new dialog window for removing time range #25954

Closed
mavduevskiy opened this issue Jul 8, 2022 · 1 comment · Fixed by #25965, Smaehtin/fenix#114 or fork-house/fenix#12
Closed

Create a new dialog window for removing time range #25954

mavduevskiy opened this issue Jul 8, 2022 · 1 comment · Fixed by #25965, Smaehtin/fenix#114 or fork-house/fenix#12
Assignees
@mavduevskiy
Labels
eng:qa:verified QA Verified
Milestone
104

Comments

@mavduevskiy
Copy link
Contributor

mavduevskiy commented Jul 8, 2022 •
edited by data-sync-user
Loading

Currently, the bin button on a history screen suggests user to remove all of the history. Create a new dialog that would offer removing a specific time range, like last hour, today and yesterday, everything/

Jira ticket: link
Design: link

┆Issue is synchronized with this Jira Task
@mavduevskiy mavduevskiy self-assigned this Jul 8, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 8, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 8, 2022
Closes mozilla-mobile#25954: add new delete time range dialog for His…
7ff4a4f 
…tory and HistoryGroup screens
@mavduevskiy mavduevskiy removed the needs:triage Issue needs triage label Jul 8, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 9, 2022
Close mozilla-mobile#25954: add a new delete time range confirmation …
d32643b 
…dialog for history screen
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 10, 2022
Close mozilla-mobile#25954: change button colours
081bd14
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 10, 2022
Close mozilla-mobile#25954: add tests for RemoteTimeFrame class
4623e0c
@mavduevskiy mavduevskiy mentioned this issue Jul 10, 2022
Merged
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 10, 2022
Closes mozilla-mobile#25954: make history menu delete icon name unive…
ba13f1f 
…rsal
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 10, 2022
Closes mozilla-mobile#25954: fix history UI test
425c3a4
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 18, 2022
Closes mozilla-mobile#25954: restore deleted unused string
ab390bb
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 18, 2022
Closes mozilla-mobile#25954: refactor DialogFragment to contain no logic
d996e36
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 18, 2022
Closes mozilla-mobile#25954: fix lint resource error
4a2f5f2
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 18, 2022
Closes mozilla-mobile#25954: add removedIn param to a removed string
cc75b9d
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 19, 2022
Closes mozilla-mobile#25954: fix failing HistoryMetadataControllerTes…
4d138bd 
…t.kt tests, remove skipping scoped tests
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 19, 2022
Closes mozilla-mobile#25954: change HistoryController to send disband…
99abf81 
… events if the timeframe removed all history, change delete dialog text color, names and style related changes
This was referenced Jul 19, 2022
Closed
Closed
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 19, 2022
Closes mozilla-mobile#25954: call RemoveAllClosedTabAction and PurgeH…
b8236aa 
…istoryAction for every time range deletion
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 20, 2022
Closes mozilla-mobile#25954: fix call ordering inside onDeleteTimeRan…
ba688be 
…geConfirmed test
JohanLorenzo pushed a commit to mavduevskiy/fenix that referenced this issue Jul 20, 2022
@JohanLorenzo
Close mozilla-mobile#25954: add a new delete time range confirmation …
f0cabba 
…dialog for history screen
JohanLorenzo pushed a commit to mavduevskiy/fenix that referenced this issue Jul 20, 2022
@JohanLorenzo
Close mozilla-mobile#25954: change button colours
3911b7e
JohanLorenzo pushed a commit to mavduevskiy/fenix that referenced this issue Jul 20, 2022
@JohanLorenzo
Close mozilla-mobile#25954: add tests for RemoteTimeFrame class
f891b90
JohanLorenzo pushed a commit to mavduevskiy/fenix that referenced this issue Jul 20, 2022
@JohanLorenzo
Closes mozilla-mobile#25954: make history menu delete icon name unive…
d6105e7 
…rsal
JohanLorenzo pushed a commit to mavduevskiy/fenix that referenced this issue Jul 20, 2022
@JohanLorenzo
Closes mozilla-mobile#25954: fix history UI test
82383fc
JohanLorenzo pushed a commit to mavduevskiy/fenix that referenced this issue Jul 20, 2022
@JohanLorenzo
Closes mozilla-mobile#25954: restore deleted unused string
1a0dd19
JohanLorenzo pushed a commit to mavduevskiy/fenix that referenced this issue Jul 20, 2022
@JohanLorenzo
Closes mozilla-mobile#25954: refactor DialogFragment to contain no logic
ea09c98
JohanLorenzo pushed a commit to mavduevskiy/fenix that referenced this issue Jul 20, 2022
@JohanLorenzo
Closes mozilla-mobile#25954: fix lint resource error
6fa5918
JohanLorenzo pushed a commit to mavduevskiy/fenix that referenced this issue Jul 20, 2022
@JohanLorenzo
Closes mozilla-mobile#25954: add removedIn param to a removed string
1b2cc25
JohanLorenzo pushed a commit to mavduevskiy/fenix that referenced this issue Jul 20, 2022
@JohanLorenzo
Closes mozilla-mobile#25954: fix failing HistoryMetadataControllerTes…
80be11c 
…t.kt tests, remove skipping scoped tests
JohanLorenzo pushed a commit to mavduevskiy/fenix that referenced this issue Jul 20, 2022
@JohanLorenzo
Closes mozilla-mobile#25954: change HistoryController to send disband…
9dc30bd 
… events if the timeframe removed all history, change delete dialog text color, names and style related changes
JohanLorenzo pushed a commit to mavduevskiy/fenix that referenced this issue Jul 20, 2022
@JohanLorenzo
Closes mozilla-mobile#25954: call RemoveAllClosedTabAction and PurgeH…
e3dfe4e 
…istoryAction for every time range deletion
JohanLorenzo pushed a commit to mavduevskiy/fenix that referenced this issue Jul 20, 2022
@JohanLorenzo
Closes mozilla-mobile#25954: fix call ordering inside onDeleteTimeRan…
a28a9e1 
…geConfirmed test
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 20, 2022
Close mozilla-mobile#25954: add a new delete time range confirmation …
dcc65b9 
…dialog for history screen
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this issue Jul 20, 2022
Close mozilla-mobile#25954: add a new delete time range confirmation …
910aa17 
…dialog for history screen
@mergify mergify bot closed this as completed in #25965 Jul 20, 2022
mergify bot pushed a commit that referenced this issue Jul 20, 2022
@mergify
Close #25954: add a new delete time range confirmation dialog for his…
7982c6b 
…tory screen
@github-actions github-actions bot added this to the 104 milestone Jul 20, 2022
@mavduevskiy mavduevskiy added the eng:qa:needed QA Needed label Jul 20, 2022
@mavduevskiy mavduevskiy reopened this Jul 20, 2022
@github-actions github-actions bot mentioned this issue Jul 21, 2022
Merged
@SoftVision-LorandJanos
Copy link

Verified as fixed on the latest Nightly 104.0a1 (2022-07-21) build.
Device used: Google Pixel 4 (Android 12).
Closing the ticket as fixed.
Screenshot_20220721-112841

@SoftVision-LorandJanos SoftVision-LorandJanos added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jul 21, 2022
@github-actions github-actions bot mentioned this issue Aug 25, 2022
Merged
This was referenced Dec 5, 2022
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mavduevskiy mavduevskiy

Labels
eng:qa:verified QA Verified
Projects
None yet
Milestone
104
2 participants
@SoftVision-LorandJanos @mavduevskiy