Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Refactor the FenixTabCounterMenu creation from HomeFragment to TabCounterBuilder #26026

Closed
gabrielluong opened this issue Jul 14, 2022 · 2 comments · Fixed by #26139, nathanmkaya/fenix#108 or fork-house/fenix#12
Closed

Refactor the FenixTabCounterMenu creation from HomeFragment to TabCounterBuilder #26026

gabrielluong opened this issue Jul 14, 2022 · 2 comments · Fixed by #26139, nathanmkaya/fenix#108 or fork-house/fenix#12
Assignees
@gabrielluong
Labels
eng:qa:verified QA Verified Feature:HomeScreen
Milestone
105

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Jul 14, 2022 •
edited by data-sync-user
Loading

Related to #24772 (comment), we want to refactor out common functionality that will be needed between the Onboarding and Home fragment.

┆Issue is synchronized with this Jira Task
@gabrielluong gabrielluong self-assigned this Jul 14, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 14, 2022
@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Jul 14, 2022
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jul 21, 2022
@gabrielluong
For mozilla-mobile#26026 - Refactor the FenixTabCounterMenu creation …
c364c85 
…from HomeFragment to TabCounterBuilder
@github-actions github-actions bot mentioned this issue Jul 21, 2022
Merged
4 tasks
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Jul 25, 2022
@gabrielluong
Copy link
Member Author

For QA, we should simply check that there is no change in functionality with the tab counter menu. This is the menu that contains the tab count and opens the tab tray. There are some functionality involving long press.

@mergify mergify bot closed this as completed in #26139 Jul 26, 2022
mergify bot pushed a commit that referenced this issue Jul 26, 2022
@gabrielluong @mergify
For #26026 - Refactor the FenixTabCounterMenu creation from HomeFragm…
8f51a99 
…ent to TabCounterBuilder
@github-actions github-actions bot reopened this Jul 26, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Jul 26, 2022
@github-actions github-actions bot added this to the 105 milestone Jul 26, 2022
@github-actions github-actions bot mentioned this issue Jul 26, 2022
Merged
@SoftVision-LorandJanos
Copy link

Verified on the latest Nightly 105.0a1 (2022-07-28) build.
Device used: Google Pixel 4 (Android 12).
Closing the ticket as verified.

@SoftVision-LorandJanos SoftVision-LorandJanos added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jul 28, 2022
@github-actions github-actions bot mentioned this issue Aug 30, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gabrielluong gabrielluong

Labels
eng:qa:verified QA Verified Feature:HomeScreen
Projects
None yet
Milestone
105
2 participants
@gabrielluong @SoftVision-LorandJanos