Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #26026 - Refactor the FenixTabCounterMenu creation from HomeFragment to TabCounterBuilder #26139

Merged
merged 2 commits into from
Jul 26, 2022
Merged

For #26026 - Refactor the FenixTabCounterMenu creation from HomeFragment to TabCounterBuilder #26139

merged 2 commits into from
Jul 26, 2022

Conversation

gabrielluong
Copy link
Member

@gabrielluong gabrielluong commented Jul 21, 2022 •
edited by github-actions bot
Loading

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

  • QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Fixes #26026

@gabrielluong gabrielluong requested review from a team as code owners July 21, 2022 23:15
@gabrielluong gabrielluong added the needs:review PRs that need to be reviewed label Jul 21, 2022
@gabrielluong
Copy link
Member Author

This will land after the cut.

MozillaNoah
MozillaNoah approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@MozillaNoah MozillaNoah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I honestly didn't know we could long press on the tab counter though.

@gabrielluong gabrielluong added pr:approved PR that has been approved pr:do-not-land pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed needs:review PRs that need to be reviewed pr:do-not-land labels Jul 22, 2022
@mergify mergify bot merged commit 8f51a99 into mozilla-mobile:main Jul 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MozillaNoah MozillaNoah MozillaNoah approved these changes

Assignees
No one assigned
Labels
pr:approved PR that has been approved pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor the FenixTabCounterMenu creation from HomeFragment to TabCounterBuilder
2 participants
@gabrielluong @MozillaNoah