Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]: [a11y] Consider increasing the contrast ratio on the Saved logins' buttons #27307

Closed
sv-amocirean opened this issue Oct 6, 2022 · 3 comments · Fixed by #27326 or nathanmkaya/fenix#108
Assignees
Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. 🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified needs:triage Issue needs triage
Milestone

Comments

@sv-amocirean
Copy link

sv-amocirean commented Oct 6, 2022

Steps to reproduce

  1. Have the Accessibility scanner app installed and opened.
  2. Go to Settings - Delete Browsing Data (under the Privacy and security section)
  3. Scan the dialogue.

Expected behaviour

No suggestions are made.

Actual behaviour

Text contrast
android:id/button1
The item's text contrast ratio is 1.54. This ratio is based on an estimated foreground color of #FF9AA2 and an estimated background color of #E0E0E5. Consider using colors that result in a contrast ratio greater than 4.50 for small text, or 3.00 for large text.

Device name

Google Pixel 6

Android version

Android 13

Firefox release type

Firefox Nightly

Firefox version

107.0a1

Device logs

No response

Additional information

image

┆Issue is synchronized with this Jira Task

@sv-amocirean sv-amocirean added needs:triage Issue needs triage 🐞 bug Crashes, Something isn't working, .. labels Oct 6, 2022
@mcarare mcarare added the access Accessibility: Talkback, HW keyboard/mouse, braile display etc. label Oct 6, 2022
@mcarare
Copy link
Contributor

mcarare commented Oct 6, 2022

@gabrielluong can you check if the DestructiveButton style uses the correct colors? TY!

@gabrielluong gabrielluong self-assigned this Oct 6, 2022
@gabrielluong
Copy link
Member

gabrielluong commented Oct 6, 2022

For reference, this is design system component for our warning buttons https://www.figma.com/file/ujdiReypSypu2GhRgzArea/Android-Components?node-id=1429%3A3084. It is indeed using the wrong colors and should be using Text Warning Button https://www.figma.com/file/pEyGeE4KV5ytYHeXMfLcEr/Mobile-Styles?node-id=1637%3A23964

gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 7, 2022
…ng_button text color for DestructiveButton
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Oct 7, 2022
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Oct 7, 2022
@mergify mergify bot closed this as completed in #27326 Oct 7, 2022
mergify bot pushed a commit that referenced this issue Oct 7, 2022
@github-actions github-actions bot reopened this Oct 7, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Oct 7, 2022
@github-actions github-actions bot added this to the 107 milestone Oct 7, 2022
@SoftVision-LorandJanos
Copy link

Manged to reproduce with the Nightly build from 2022-10-06 (107.0a1).
Verified as fixed on the latest Nightly 107.0a1 (2022-10-09T17...) build.
There is no text contrast ratio suggestion displayed.
Device used: Oppo Find X5 (Android 12).
Closing the ticket as fixed.
Screenshot_2022-10-10-07-57-24-27_80a9469f53bfe75dbc6e8989be28e2f0

@SoftVision-LorandJanos SoftVision-LorandJanos added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Oct 10, 2022
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Feb 14, 2023
…on text and icon color for DestructiveButton
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc. 🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified needs:triage Issue needs triage
Projects
None yet
4 participants