Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #27307 - Use the correct warning button text and icon color for DestructiveButton #27326

Merged
merged 3 commits into from
Oct 7, 2022

Conversation

gabrielluong
Copy link
Member

@gabrielluong gabrielluong commented Oct 7, 2022

For reference, this is design system component for our warning buttons https://www.figma.com/file/ujdiReypSypu2GhRgzArea/Android-Components?node-id=1429%3A3084

Old New
194330100-e0a1f2cd-0bd8-4652-aa71-e408baf19daf Screen Shot 2022-10-07 at 11 01 12 AM

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

  • QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Fixes #27307

@gabrielluong gabrielluong marked this pull request as ready for review October 7, 2022 15:03
@gabrielluong gabrielluong requested review from a team as code owners October 7, 2022 15:03
@gabrielluong gabrielluong added the needs:review PRs that need to be reviewed label Oct 7, 2022
@gabrielluong gabrielluong added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed needs:review PRs that need to be reviewed labels Oct 7, 2022
@mergify mergify bot merged commit b6b892f into mozilla-mobile:main Oct 7, 2022
@gabrielluong gabrielluong deleted the 27307 branch October 7, 2022 18:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: [a11y] Consider increasing the contrast ratio on the Saved logins' buttons
2 participants