Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Bug 1803117 - disable by default cookieBannerHandlingModePrivateBrowsing #233

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Bug 1803117 - disable by default cookieBannerHandlingModePrivateBrowsing #233

merged 1 commit into from
Nov 29, 2022

Conversation

Amejia481
Copy link
Contributor

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

GitHub Automation

Used by GitHub Actions.

@Amejia481 Amejia481 added the 🕵️‍♀️ needs review PRs that need to be reviewed label Nov 29, 2022
@Amejia481
Copy link
Contributor Author

This should disabled feature and address mozilla-mobile/fenix#27719, I verifying locally just to make sure!

boek
boek approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@boek boek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Amejia481 Amejia481 closed this Nov 29, 2022
@Amejia481 Amejia481 reopened this Nov 29, 2022
@Amejia481 Amejia481 closed this Nov 29, 2022
@Amejia481 Amejia481 reopened this Nov 29, 2022
@Amejia481
Copy link
Contributor Author

Verified locally!

@Amejia481 Amejia481 added 🛬 needs landing PRs that are ready to land and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Nov 29, 2022
@mergify mergify bot merged commit b709ce3 into mozilla-mobile:releases_v108 Nov 29, 2022
@Amejia481
Copy link
Contributor Author

https://github.com/Mergifyio backport main

@mergify mergify bot mentioned this pull request Dec 1, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Dec 1, 2022

backport main

✅ Backports have been created

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@boek boek boek approved these changes

@rocketsroger rocketsroger Awaiting requested review from rocketsroger

Assignees
No one assigned
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Amejia481 @boek