Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Make a “@LightDarkPreview()” annotation that makes two previews from one annotation #28201

Closed
2 tasks
Tracked by #24339
HarrisonOg opened this issue Dec 14, 2022 · 1 comment · Fixed by #28202, C-EO/fenix#4 or fork-house/fenix#14
Closed
2 tasks
Tracked by #24339
Assignees
Labels
compose Tickets involving Composable changes eng:health Improve code health
Milestone

Comments

@HarrisonOg
Copy link
Contributor

HarrisonOg commented Dec 14, 2022

Currently we use two annotations in Compose Preview functions in order to display previews with both dark mode on and off.

This task is for creating a multi-annotation class that wraps both of these annotations into a single annotation, helping with readability and any future extension of the multi-annotation so it will include other rendering options.

Tasks:

  • Create multi-annotation for both dark mode on and off
  • Replace all uses of the two annotations with the single multi-annotation

┆Issue is synchronized with this Jira Task

@HarrisonOg HarrisonOg self-assigned this Dec 14, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Dec 14, 2022
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Dec 14, 2022
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Dec 14, 2022
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Dec 14, 2022
@MozillaNoah MozillaNoah added eng:health Improve code health compose Tickets involving Composable changes and removed needs:triage Issue needs triage labels Dec 14, 2022
@Mugurell
Copy link
Contributor

There was also #25258 for including more configurations.

HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Dec 15, 2022
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Dec 15, 2022
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Dec 19, 2022
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Dec 19, 2022
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Dec 19, 2022
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Jan 3, 2023
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Jan 3, 2023
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Jan 4, 2023
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Jan 4, 2023
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Jan 4, 2023
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Jan 4, 2023
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Jan 4, 2023
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Jan 5, 2023
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Jan 5, 2023
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Jan 5, 2023
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Jan 5, 2023
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Jan 5, 2023
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Jan 5, 2023
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Jan 5, 2023
HarrisonOg added a commit to HarrisonOg/fenix that referenced this issue Jan 5, 2023
@mergify mergify bot closed this as completed in #28202 Jan 6, 2023
mergify bot pushed a commit that referenced this issue Jan 6, 2023
Add LightDarkPreview annotation
mergify bot pushed a commit that referenced this issue Jan 6, 2023
@github-actions github-actions bot added this to the 110 milestone Jan 6, 2023
JohanLorenzo pushed a commit to mozilla-releng/staging-firefox-android that referenced this issue Jan 12, 2023
JohanLorenzo pushed a commit to mozilla-releng/staging-firefox-android that referenced this issue Jan 12, 2023
…preview annotations with LightDarkPreview annotation
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
compose Tickets involving Composable changes eng:health Improve code health
Projects
None yet
3 participants