This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Make a “@LightDarkPreview()” annotation that makes two previews from one annotation #28201
Closed
2 tasks
Tracked by
#24339
HarrisonOg opened this issue
Dec 14, 2022
· 1 comment
· Fixed by #28202, C-EO/fenix#4 or fork-house/fenix#14
Closed
2 tasks
Tracked by
#24339
Make a “@LightDarkPreview()” annotation that makes two previews from one annotation #28201
HarrisonOg opened this issue
Dec 14, 2022
· 1 comment
· Fixed by #28202, C-EO/fenix#4 or fork-house/fenix#14
Labels
Milestone
Comments
30 tasks
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Dec 14, 2022
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Dec 14, 2022
4 tasks
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Dec 14, 2022
MozillaNoah
added
eng:health
Improve code health
compose
Tickets involving Composable changes
and removed
needs:triage
Issue needs triage
labels
Dec 14, 2022
There was also #25258 for including more configurations. |
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Dec 15, 2022
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Dec 15, 2022
Add LightDarkPreview annotation
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Dec 19, 2022
Add LightDarkPreview annotation
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Dec 19, 2022
Add LightDarkPreview annotation
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Dec 19, 2022
Add LightDarkPreview annotation
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 3, 2023
Add LightDarkPreview annotation
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 3, 2023
Add LightDarkPreview annotation
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 4, 2023
…tions with LightDarkPreview annotation
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 4, 2023
Add LightDarkPreview annotation
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 4, 2023
…tions with LightDarkPreview annotation
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 4, 2023
Add LightDarkPreview annotation
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 4, 2023
…tions with LightDarkPreview annotation
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 5, 2023
Add LightDarkPreview annotation
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 5, 2023
…tions with LightDarkPreview annotation
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 5, 2023
Add LightDarkPreview annotation
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 5, 2023
…tions with LightDarkPreview annotation
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 5, 2023
Add LightDarkPreview annotation
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 5, 2023
…tions with LightDarkPreview annotation
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 5, 2023
Add LightDarkPreview annotation
HarrisonOg
added a commit
to HarrisonOg/fenix
that referenced
this issue
Jan 5, 2023
…tions with LightDarkPreview annotation
JohanLorenzo
pushed a commit
to mozilla-releng/staging-firefox-android
that referenced
this issue
Jan 12, 2023
…tation Add LightDarkPreview annotation
JohanLorenzo
pushed a commit
to mozilla-releng/staging-firefox-android
that referenced
this issue
Jan 12, 2023
…preview annotations with LightDarkPreview annotation
This was referenced Feb 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently we use two annotations in Compose Preview functions in order to display previews with both dark mode on and off.
This task is for creating a multi-annotation class that wraps both of these annotations into a single annotation, helping with readability and any future extension of the multi-annotation so it will include other rendering options.
Tasks:
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: