Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Tabs Tray Refactor] Remove BrowserTrayInteractor and BrowserTrayController and relocate the implemented functions to TabsTrayInteractor and TabsTrayController #28266

Closed
Tracked by #25722
MozillaNoah opened this issue Dec 20, 2022 · 1 comment · Fixed by #28584
Closed
Tracked by #25722

[Tabs Tray Refactor] Remove BrowserTrayInteractor and BrowserTrayController and relocate the implemented functions to TabsTrayInteractor and TabsTrayController #28266

MozillaNoah opened this issue Dec 20, 2022 · 1 comment · Fixed by #28584
Assignees
@MozillaNoah
Labels
eng:health Improve code health eng:qa:verified QA Verified Feature:Tabs
Milestone
111

Comments

@MozillaNoah
Copy link
Contributor

MozillaNoah commented Dec 20, 2022 •
edited

Meta issue:

All/most/some of this was already done as a part of #25895, but is being split out so it can be more safely landed.

Notes for QA: This is a business logic refactor in the tabs tray, so the existing functionality should remain the same. Please validate that no there have been no regressions involving tabs in the tabs tray.

┆Issue is synchronized with this Jira Task
@MozillaNoah MozillaNoah added eng:health Improve code health Feature:Tabs labels Dec 20, 2022
@MozillaNoah MozillaNoah self-assigned this Dec 20, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Dec 20, 2022
@MozillaNoah MozillaNoah mentioned this issue Dec 20, 2022
Closed
13 tasks
@MozillaNoah MozillaNoah removed the needs:triage Issue needs triage label Dec 20, 2022
@MozillaNoah MozillaNoah mentioned this issue Jan 13, 2023
Merged
4 tasks
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Jan 18, 2023
@github-actions github-actions bot mentioned this issue Jan 18, 2023
Merged
4 tasks
@mergify mergify bot closed this as completed in #28584 Jan 24, 2023
mergify bot pushed a commit that referenced this issue Jan 24, 2023
@MozillaNoah @mergify
For #28266 - Merge BrowserTrayInteractor into TabsTrayInteractor
411bd55
@github-actions github-actions bot reopened this Jan 24, 2023
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Jan 24, 2023
@github-actions github-actions bot added this to the 111 milestone Jan 24, 2023
JohanLorenzo pushed a commit to mozilla-releng/staging-firefox-android that referenced this issue Jan 25, 2023
@MozillaNoah @mergify
[fenix] For mozilla-mobile/fenix#28266 - Merge `BrowserTrayInteractor…
f0dd1c6 
…` into `TabsTrayInteractor`
@delia-pop
Copy link

Verified as fixed on latest Nightly from 01/27 with Google Pixel 6 (Android 13). No regressions were observed.

@delia-pop delia-pop added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MozillaNoah MozillaNoah

Labels
eng:health Improve code health eng:qa:verified QA Verified Feature:Tabs
Projects
None yet
Milestone
111
Development

Successfully merging a pull request may close this issue.

For #28266 - Merge BrowserTrayInteractor into TabsTrayInteractor MozillaNoah/fenix
2 participants
@MozillaNoah @delia-pop