-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #28266 - Merge BrowserTrayInteractor
into TabsTrayInteractor
#28584
For #28266 - Merge BrowserTrayInteractor
into TabsTrayInteractor
#28584
Conversation
|
||
/** | ||
* Default tabs tray dialog implementation for overriding the default on back pressed. | ||
*/ | ||
class TabsTrayDialog( | ||
context: Context, | ||
theme: Int, | ||
private val interactor: () -> BrowserTrayInteractor, | ||
private val interactor: () -> TabsTrayInteractor, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious why couldn't we pass the TabsTrayInteractor
directly here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd have to double check, but this smelled like a hack to get around a race condition or dependency issue, so that a lambda could be called after onStart, or something, to provide the interactor, rather than have the interactor as a compile time dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TabsTrayDialog
is created in TabsTrayFragment.onCreateDialog
, while tabsTrayInteractor
inside of TabsTrayFragment
is a lateinit and instantiated inside onViewCreated
PR 6 of 10 for:
Pull Request checklist
QA
To download an APK when reviewing a PR (after all CI tasks finished running):
Checks
at the top of the PR page.firefoxci-taskcluster
group on the left to expand all tasks.build-debug
task.View task in Taskcluster
in the newDETAILS
section.GitHub Automation
Fixes #28266