Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

URL Box View background not shown in Browser Fragment #364

Closed
ekager opened this issue Feb 1, 2019 · 0 comments
Closed

URL Box View background not shown in Browser Fragment #364

ekager opened this issue Feb 1, 2019 · 0 comments
Assignees
@sblatz
Milestone
Sprint 2-1 (Miles...

Comments

@ekager
Copy link
Contributor

ekager commented Feb 1, 2019 •
edited by data-sync-user

When we added the ToolbarUIView and ToolbarComponent, we moved the urlBoxView (and similar) to ToolbarUIView, but BrowserFragment doesn't currently use the ToolbarComponent so the url box view background isn't there anymore.

Steps to reproduce

Look at Browser Fragment

Expected behavior

URL background appears

Actual behavior

No URL Background

Device information

  • Android device: ?
  • Fenix version: ?

┆Issue is synchronized with this Jira Task
boek added a commit to boek/fenix that referenced this issue Feb 4, 2019
@boek
For mozilla-mobile#364 - Moves edit mode to be a part of the toolbar …
61dfdd4 
…component state
boek added a commit to boek/fenix that referenced this issue Feb 4, 2019
@boek
For mozilla-mobile#364 - Refactors BrowserFragment to use the Toolbar…
db3ba8a 
…Component
boek added a commit to boek/fenix that referenced this issue Feb 4, 2019
@boek
For mozilla-mobile#364 - Refactors BrowserFragment to use the Toolbar…
4c6445f 
…Component
boek added a commit to boek/fenix that referenced this issue Feb 4, 2019
@boek @sblatz @ekager
For mozilla-mobile#364 - Moves edit mode to be a part of the toolbar …
33e4ce8 
…component state

Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
Co-authored-by: Emily Kager <emilykager@gmail.com>
boek added a commit to boek/fenix that referenced this issue Feb 4, 2019
@boek @sblatz @ekager
For mozilla-mobile#364 - Refactors BrowserFragment to use the Toolbar…
d50e399 
…Component

Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
Co-authored-by: Emily Kager <emilykager@gmail.com>
boek added a commit that referenced this issue Feb 5, 2019
@boek @sblatz @ekager
For #364 - Moves edit mode to be a part of the toolbar component state
dbea570 
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
Co-authored-by: Emily Kager <emilykager@gmail.com>
boek added a commit that referenced this issue Feb 5, 2019
@boek @sblatz @ekager
For #364 - Refactors BrowserFragment to use the ToolbarComponent
461664e 
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
Co-authored-by: Emily Kager <emilykager@gmail.com>
@boek boek closed this as completed Feb 5, 2019
@boek boek added this to the Sprint 3 (M2) milestone Feb 5, 2019
@boek boek mentioned this issue Feb 5, 2019
Closed
@ghost ghost assigned sblatz Feb 8, 2019
sblatz added a commit that referenced this issue Feb 8, 2019
@sblatz
Closes #363 & Closes #364: Adds private browsing theme (#405)
d09dc14 
* For #345 #346 - Adds private browsing theme

Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>

* Abstracts theme management

* Theme browser toolbar

* Remove unused imports

* Begin work on sharedPreferences

* fix lint

* #346 - Refactors ThemeManager to take a callback

* Adds clean status bar and nav bar

* lint

* Themes settings icons better

* Small clean up
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sblatz sblatz

Labels
None yet
Projects
None yet
Milestone
Sprint 2-1 (Milestone 2)
Development

No branches or pull requests
3 participants
@boek @sblatz @ekager