Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Create home view for private browsing #346

Closed
sblatz opened this issue Feb 1, 2019 · 2 comments
Closed

Create home view for private browsing #346

sblatz opened this issue Feb 1, 2019 · 2 comments
Assignees
@sblatz
Labels
feature request 🌟 New functionality and improvements
Milestone
Sprint 2-1 (Miles...

Comments

@sblatz
Copy link
Contributor

sblatz commented Feb 1, 2019 •
edited by data-sync-user
Loading

Parent: #277

  • Add the delete session button that appears on the home view when in private browsing mode.
  • Add the private browsing explainer text that appears when you're on the home view with no tabs open
  • Add logic to enter/leave private browsing from home view
  • Add logic to enter/leave private browsing from menu item

Mock-ups found here

┆Issue is synchronized with this Jira Task
@sblatz sblatz changed the title Add "delete session button Add "delete session" button for private browsing Feb 1, 2019
@sblatz sblatz changed the title Add "delete session" button for private browsing Create home view for private browsing Feb 1, 2019
@sblatz sblatz mentioned this issue Feb 1, 2019
Closed
@boek boek added this to the Milestone 2 Backlog milestone Feb 1, 2019
@bbinto bbinto added the size M label Feb 1, 2019
@sblatz sblatz self-assigned this Feb 4, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Feb 4, 2019
@sblatz
For mozilla-mobile#346: Switches background color
e7125ae
sblatz added a commit to sblatz/fenix that referenced this issue Feb 4, 2019
@sblatz
For mozilla-mobile#346: Adds better private browsing button
d978b18
sblatz added a commit to sblatz/fenix that referenced this issue Feb 4, 2019
@sblatz
For mozilla-mobile#346: Persist private mode theme
9d3ecc1
sblatz added a commit to sblatz/fenix that referenced this issue Feb 4, 2019
@sblatz
For mozilla-mobile#346 Adds status bar theming
680bacb
sblatz added a commit to sblatz/fenix that referenced this issue Feb 4, 2019
@sblatz
For mozilla-mobile#346: Enter private mode from browser
75957c8
@sblatz
Copy link
Contributor Author

sblatz commented Feb 4, 2019

This ticket will likely end up being on the larger size of medium due to needing to refactor it to the new architecture.

sblatz added a commit to sblatz/fenix that referenced this issue Feb 5, 2019
@sblatz
For mozilla-mobile#346: Plays nicely with Jeff's pretty animations
7c516b1
sblatz added a commit to sblatz/fenix that referenced this issue Feb 5, 2019
@sblatz
For mozilla-mobile#346: Plays nicely with Jeff's pretty animations
a74361f
boek added a commit to boek/fenix that referenced this issue Feb 7, 2019
@boek @sblatz
For mozilla-mobile#345 mozilla-mobile#346 - Adds private browsing theme
cc361f0 
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
boek added a commit to sblatz/fenix that referenced this issue Feb 8, 2019
@boek
mozilla-mobile#346 - Refactors ThemeManager to take a callback
4195fbd
sblatz added a commit that referenced this issue Feb 8, 2019
@sblatz
Closes #363 & Closes #364: Adds private browsing theme (#405)
d09dc14 
* For #345 #346 - Adds private browsing theme

Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>

* Abstracts theme management

* Theme browser toolbar

* Remove unused imports

* Begin work on sharedPreferences

* fix lint

* #346 - Refactors ThemeManager to take a callback

* Adds clean status bar and nav bar

* lint

* Themes settings icons better

* Small clean up
@sblatz
Copy link
Contributor Author

sblatz commented Feb 8, 2019

Closed by #405

@sblatz sblatz closed this as completed Feb 8, 2019
@bbinto bbinto added the feature request 🌟 New functionality and improvements label Feb 11, 2019
@data-sync-user data-sync-user changed the title Create home view for private browsing FNX3-17032 ⁃ Create home view for private browsing Aug 11, 2020
@kbrosnan kbrosnan changed the title FNX3-17032 ⁃ Create home view for private browsing Create home view for private browsing Aug 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sblatz sblatz

Labels
feature request 🌟 New functionality and improvements
Projects
None yet
Milestone
Sprint 2-1 (Milestone 2)
Development

No branches or pull requests
5 participants
@bbinto @kbrosnan @boek @sblatz @data-sync-user