Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Implement SearchEngineProvider using MLS #3637

Closed
pocmo opened this issue Jul 3, 2019 · 3 comments
Closed

Implement SearchEngineProvider using MLS #3637

pocmo opened this issue Jul 3, 2019 · 3 comments
Assignees
Labels
🌟 feature New functionality and improvements 🐉 Fenix Feature needed for Fenix <search> Component: browser-search
Milestone

Comments

@pocmo
Copy link
Contributor

pocmo commented Jul 3, 2019

Also see: #1720, mozilla-mobile/fenix#3869

In Fennec we do a region lookup via MLS. Let's port this to AC so that we can use it in Fenix. Our updated list.json requires a region and using the locale for that is not that helpful.

┆Issue is synchronized with this Jira Task

@pocmo pocmo added 🌟 feature New functionality and improvements <search> Component: browser-search 🐉 Fenix Feature needed for Fenix labels Jul 3, 2019
@boek boek added this to the 3.0.0 🏴‍☠️ milestone Jul 3, 2019
@vesta0 vesta0 self-assigned this Jul 8, 2019
@vesta0
Copy link
Collaborator

vesta0 commented Jul 9, 2019

Spoke to Mike, let's try to fix this in this sprint please.

@vesta0 vesta0 removed their assignment Jul 9, 2019
@pocmo
Copy link
Contributor Author

pocmo commented Jul 9, 2019

@pocmo pocmo removed this from the 3.0.0 🏴‍☠️ milestone Jul 9, 2019
@pocmo pocmo self-assigned this Jul 15, 2019
pocmo added a commit to pocmo/android-components that referenced this issue Jul 17, 2019
pocmo added a commit to pocmo/android-components that referenced this issue Jul 18, 2019
pocmo added a commit to pocmo/android-components that referenced this issue Jul 23, 2019
pocmo added a commit that referenced this issue Jul 23, 2019
@pocmo
Copy link
Contributor Author

pocmo commented Jul 29, 2019

Moving this out of the sprint. Filed #3934 which seems to be a prerequisite to finishing this.

pocmo added a commit to pocmo/android-components that referenced this issue Aug 20, 2019
…urn data class instead of single properties.
pocmo added a commit to pocmo/android-components that referenced this issue Aug 20, 2019
@pocmo pocmo added this to the 10.0.0 🏊 milestone Aug 20, 2019
pocmo added a commit to pocmo/android-components that referenced this issue Aug 20, 2019
…urn data class instead of single properties.
pocmo added a commit to pocmo/android-components that referenced this issue Aug 20, 2019
pocmo added a commit to pocmo/android-components that referenced this issue Aug 20, 2019
pocmo added a commit to pocmo/android-components that referenced this issue Aug 21, 2019
…urn data class instead of single properties.
pocmo added a commit to pocmo/android-components that referenced this issue Aug 21, 2019
bors bot pushed a commit that referenced this issue Aug 21, 2019
4162: Closes #3637: Add SearchLocalizationProvider implementation that uses MozillaLocationService r=Amejia481 a=pocmo



Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
@bors bors bot closed this as completed in 205e926 Aug 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🌟 feature New functionality and improvements 🐉 Fenix Feature needed for Fenix <search> Component: browser-search
Projects
None yet
Development

No branches or pull requests

3 participants